starknet_transaction_prover: global panic hook + graceful SIGTERM shutdown#14166
starknet_transaction_prover: global panic hook + graceful SIGTERM shutdown#14166avi-starkware wants to merge 1 commit into
Conversation
PR SummaryLow Risk Overview A new
Dependencies: Reviewed by Cursor Bugbot for commit c3950e4. Bugbot is set up for automated code reviews on this repo. Configure here. |
63d34df to
c31ce65
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c31ce65. Configure here.
| return s.clone(); | ||
| } | ||
| "<non-string panic payload>".to_string() | ||
| } |
There was a problem hiding this comment.
Reimplements already-stable standard library method
Low Severity
The extract_payload function manually reimplements PanicHookInfo::payload_as_str(), which was stabilized in Rust 1.91.0. The project's rust-toolchain.toml specifies channel 1.95, so the standard library method is already available. The doc comment on extract_payload references a nightly-2025-07-14 toolchain that no longer matches the project's actual pinned toolchain, making the stated reason for the workaround stale.
Reviewed by Cursor Bugbot for commit c31ce65. Configure here.
There was a problem hiding this comment.
Actually, the crate starknet_transaction_prover uses the referenced nightly toolchain, so the doc comment is not stale
c31ce65 to
72a08b0
Compare
2dcb716 to
f83f30c
Compare
72a08b0 to
17dbfd9
Compare
f83f30c to
53b6a1e
Compare
17dbfd9 to
9845d29
Compare
9845d29 to
4d23115
Compare
53b6a1e to
4645e9b
Compare
…tdown Installs a process-wide panic hook that emits one structured `event=panic` tracing event with location and backtrace, and bridges SIGTERM/SIGINT into `ServerHandle::stop` so container teardown becomes visible in logs and in-flight proofs get to finish. A second signal forces `exit(1)` to work around tokio-rs/tokio#7905. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4d23115 to
c3950e4
Compare
4645e9b to
278ffaa
Compare



Installs a process-wide panic hook that emits one structured
event=panictracing event with location and backtrace, and bridges SIGTERM/SIGINT into
ServerHandle::stopso container teardown becomes visible in logs andin-flight proofs get to finish. A second signal forces
exit(1)to workaround tokio-rs/tokio#7905.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com