starknet_transaction_prover: redact URL credentials in logs and add startup banner#14164
Conversation
PR SummaryLow Risk Overview Startup now emits a structured banner (version, git SHA, chain id, redacted RPC host, fee-validation and blocking-check flags, OHTTP) instead of risking full URLs or other sensitive config in log sinks. CLI override messages for Reviewed by Cursor Bugbot for commit 170c535. Bugbot is set up for automated code reviews on this repo. Configure here. |
c26d49f to
962afc1
Compare
0df4834 to
1f5f854
Compare
1f5f854 to
abc893a
Compare
962afc1 to
435cc58
Compare
einat-starkware
left a comment
There was a problem hiding this comment.
@einat-starkware reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on avi-starkware).
…tartup banner Adds `redact_url_host` which collapses a URL to `scheme://host[:port]`, dropping userinfo, path, and query. The CLI-override logs for `rpc_node_url` and `blocking_check_url` and a new startup banner all route through it so credentials embedded in those URLs cannot reach a log sink. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
abc893a to
170c535
Compare
avi-starkware
left a comment
There was a problem hiding this comment.
@avi-starkware reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on avi-starkware).

Adds
redact_url_hostwhich collapses a URL toscheme://host[:port],dropping userinfo, path, and query. The CLI-override logs for
rpc_node_urlandblocking_check_urland a new startup banner allroute through it so credentials embedded in those URLs cannot reach a log
sink.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com