add section when to return result#13635
Open
ShahakShama wants to merge 1 commit intoshahak/style-guide-error-suffixfrom
Open
add section when to return result#13635ShahakShama wants to merge 1 commit intoshahak/style-guide-error-suffixfrom
ShahakShama wants to merge 1 commit intoshahak/style-guide-error-suffixfrom
Conversation
This was referenced Mar 31, 2026
Collaborator
Author
This was referenced Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Low Risk
Low risk documentation-only change that doesn’t affect runtime behavior. Minor risk of shifting team conventions around error propagation/panics.
Overview
Adds a new “When to return
Result” section tostyle.md, advising to returnResultonly for errors callers are expected to handle.Recommends panicking at the source when failure should abort, and handling/logging internally when errors are intentionally ignored, rather than forcing callers to discard results.
Written by Cursor Bugbot for commit 0e7c9a6. This will update automatically on new commits. Configure here.