delete combinators section#13416
Open
ShahakShama wants to merge 1 commit intoshahak/style-guide-test-namesfrom
Open
delete combinators section#13416ShahakShama wants to merge 1 commit intoshahak/style-guide-test-namesfrom
ShahakShama wants to merge 1 commit intoshahak/style-guide-test-namesfrom
Conversation
|
This change is |
This was referenced Mar 23, 2026
Open
Open
Open
Open
create misc section, move stuff into it, and order by importance (no erasure of anything yet)
#13112
Open
ShahakShama
force-pushed
the
shahak/style-guide-test-names
branch
from
01a819e to
8e233b9
Compare
ShahakShama
force-pushed
the
shahak/delete_combinators_section
branch
from
183e706 to
6ceac1a
Compare
ShahakShama
force-pushed
the
shahak/style-guide-test-names
branch
from
8e233b9 to
beca173
Compare
ShahakShama
force-pushed
the
shahak/delete_combinators_section
branch
from
6ceac1a to
83b0fa0
Compare
ShahakShama
force-pushed
the
shahak/style-guide-test-names
branch
from
beca173 to
bb84c16
Compare
ShahakShama
force-pushed
the
shahak/delete_combinators_section
branch
2 times, most recently
from
1c6d5c4 to
694e16c
Compare
ShahakShama
force-pushed
the
shahak/style-guide-test-names
branch
from
bb84c16 to
0448af8
Compare
Stavbe
approved these changes
Mar 30, 2026
Contributor
Stavbe
left a comment
Stavbe
left a comment
There was a problem hiding this comment.
@Stavbe reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ShahakShama).
This was referenced Mar 31, 2026
ShahakShama
force-pushed
the
shahak/delete_combinators_section
branch
from
694e16c to
7ef43a2
Compare
ShahakShama
force-pushed
the
shahak/style-guide-test-names
branch
2 times, most recently
from
33c2542 to
8780138
Compare
ShahakShama
force-pushed
the
shahak/delete_combinators_section
branch
2 times, most recently
from
7d5213a to
d9860c9
Compare
ShahakShama
force-pushed
the
shahak/style-guide-test-names
branch
from
32661c4 to
6c01bd8
Compare
ShahakShama
force-pushed
the
shahak/delete_combinators_section
branch
from
d9860c9 to
33332ed
Compare
ShahakShama
force-pushed
the
shahak/style-guide-test-names
branch
from
6c01bd8 to
36c715b
Compare
ShahakShama
force-pushed
the
shahak/delete_combinators_section
branch
from
33332ed to
2eb38fc
Compare
ShahakShama
force-pushed
the
shahak/delete_combinators_section
branch
from
2eb38fc to
7a291b1
Compare
ShahakShama
force-pushed
the
shahak/style-guide-test-names
branch
from
36c715b to
3afc1cd
Compare
ShahakShama
force-pushed
the
shahak/delete_combinators_section
branch
from
7a291b1 to
78f8f57
Compare
ShahakShama
force-pushed
the
shahak/style-guide-test-names
branch
from
0b8b63c to
8f19659
Compare
ShahakShama
force-pushed
the
shahak/delete_combinators_section
branch
from
78f8f57 to
23275c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Documentation-only change with no impact on runtime behavior or APIs.
Overview
Removes the
Combinatorsguidance section fromstyle.md, including the recommendation to avoid side effects inmap/filter/zipand the accompanying BAD/GOOD example.Written by Cursor Bugbot for commit 694e16c. This will update automatically on new commits. Configure here.