Skip to content

remove sections of re-export#13266

Open
ShahakShama wants to merge 1 commit intoshahak/style-guide-loggingfrom
shahak/style-guide-remove-reexports
Open

remove sections of re-export#13266
ShahakShama wants to merge 1 commit intoshahak/style-guide-loggingfrom
shahak/style-guide-remove-reexports

Conversation

@ShahakShama
Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama commented Mar 15, 2026

Note

Low Risk
Low risk: documentation-only change with no impact on runtime behavior or APIs.

Overview
Deletes the Re-exports sections from style.md, removing previously documented guidance and examples discouraging internal and external pub use re-exports.

Written by Cursor Bugbot for commit 10bebc8. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@ShahakShama ShahakShama force-pushed the shahak/style-guide-duplicate-tests branch from cf9ec1f to 0aeb0a3 Compare March 15, 2026 14:58
@ShahakShama ShahakShama force-pushed the shahak/style-guide-remove-reexports branch from e18dbad to 16db7bb Compare March 15, 2026 14:58
@ShahakShama ShahakShama force-pushed the shahak/style-guide-duplicate-tests branch from 0aeb0a3 to ef8b5f6 Compare March 16, 2026 07:38
@ShahakShama ShahakShama force-pushed the shahak/style-guide-remove-reexports branch from 16db7bb to 6cd6c43 Compare March 16, 2026 07:38
Copy link
Copy Markdown
Contributor

@Stavbe Stavbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stavbe reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ShahakShama).

@ShahakShama ShahakShama force-pushed the shahak/style-guide-duplicate-tests branch from ef8b5f6 to 92e1236 Compare March 26, 2026 07:20
@ShahakShama ShahakShama force-pushed the shahak/style-guide-remove-reexports branch from 6cd6c43 to 21ed7cb Compare March 26, 2026 07:20
@ShahakShama ShahakShama changed the base branch from shahak/style-guide-duplicate-tests to graphite-base/13266 March 26, 2026 07:27
@ShahakShama ShahakShama force-pushed the graphite-base/13266 branch from 92e1236 to 5a76371 Compare March 26, 2026 07:27
@ShahakShama ShahakShama force-pushed the shahak/style-guide-remove-reexports branch from 21ed7cb to 10bebc8 Compare March 26, 2026 07:27
@ShahakShama ShahakShama changed the base branch from graphite-base/13266 to shahak/style-guide-logging March 26, 2026 07:27
@ShahakShama ShahakShama force-pushed the shahak/style-guide-remove-reexports branch 2 times, most recently from 524983a to bb4ea3e Compare April 9, 2026 11:50
@ShahakShama ShahakShama force-pushed the shahak/style-guide-logging branch 2 times, most recently from 8ab1a84 to bc17c45 Compare April 9, 2026 12:12
@ShahakShama ShahakShama force-pushed the shahak/style-guide-remove-reexports branch from bb4ea3e to 79bef09 Compare April 9, 2026 12:12
@ShahakShama ShahakShama force-pushed the shahak/style-guide-logging branch from bc17c45 to be21232 Compare April 9, 2026 12:15
@ShahakShama ShahakShama force-pushed the shahak/style-guide-remove-reexports branch from 79bef09 to 3f0e80c Compare April 9, 2026 12:15
@ShahakShama ShahakShama force-pushed the shahak/style-guide-remove-reexports branch from 3f0e80c to 8242310 Compare April 13, 2026 10:51
@ShahakShama ShahakShama force-pushed the shahak/style-guide-remove-reexports branch from 8242310 to d494baa Compare April 15, 2026 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants