Skip to content

remove track_caller sentence#13267

Open
ShahakShama wants to merge 1 commit intoshahak/style-guide-remove-reexportsfrom
shahak/style-guide-remove-track-caller
Open

remove track_caller sentence#13267
ShahakShama wants to merge 1 commit intoshahak/style-guide-remove-reexportsfrom
shahak/style-guide-remove-track-caller

Conversation

@ShahakShama
Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama commented Mar 15, 2026

Note

Low Risk
Low risk documentation-only change that removes a single testing recommendation; no code or behavior changes.

Overview
Removes the #[track_caller] recommendation from the Testing section in style.md, leaving the remaining guidance on writing debuggable assertions and structuring tests unchanged.

Written by Cursor Bugbot for commit dcc3953. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@ShahakShama ShahakShama force-pushed the shahak/style-guide-remove-reexports branch from 16db7bb to 6cd6c43 Compare March 16, 2026 07:38
@ShahakShama ShahakShama force-pushed the shahak/style-guide-remove-track-caller branch from 3c533d0 to 3919551 Compare March 16, 2026 07:38
Copy link
Copy Markdown
Contributor

@Stavbe Stavbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stavbe made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on ShahakShama).


style.md line 69 at r1 (raw file):

-   Resolving merge conflicts: AI tends sometimes to just pick our changes without thinking about it.

## Testing

Don't we want to put here the naming convention for tests?

Copy link
Copy Markdown
Collaborator Author

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahakShama made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on Stavbe).


style.md line 69 at r1 (raw file):

Previously, Stavbe wrote…

Don't we want to put here the naming convention for tests?

Yes. Later PR in this stack :)

Copy link
Copy Markdown
Collaborator Author

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahakShama made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on Stavbe).


style.md line 69 at r1 (raw file):

Previously, ShahakShama wrote…

Yes. Later PR in this stack :)

#13276

Copy link
Copy Markdown
Contributor

@Stavbe Stavbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stavbe reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ShahakShama).

@ShahakShama ShahakShama force-pushed the shahak/style-guide-remove-track-caller branch from 3919551 to 4f1503e Compare March 26, 2026 07:20
@ShahakShama ShahakShama force-pushed the shahak/style-guide-remove-reexports branch from 6cd6c43 to 21ed7cb Compare March 26, 2026 07:20
@ShahakShama ShahakShama force-pushed the shahak/style-guide-remove-track-caller branch from 4f1503e to dcc3953 Compare March 26, 2026 07:27
@ShahakShama ShahakShama force-pushed the shahak/style-guide-remove-reexports branch from 21ed7cb to 10bebc8 Compare March 26, 2026 07:27
@ShahakShama ShahakShama force-pushed the shahak/style-guide-remove-reexports branch from 10bebc8 to 524983a Compare April 9, 2026 10:28
@ShahakShama ShahakShama force-pushed the shahak/style-guide-remove-track-caller branch from dcc3953 to 34ae200 Compare April 9, 2026 10:28
@ShahakShama ShahakShama force-pushed the shahak/style-guide-remove-reexports branch from 524983a to bb4ea3e Compare April 9, 2026 11:50
@ShahakShama ShahakShama force-pushed the shahak/style-guide-remove-track-caller branch from 34ae200 to 7d46d5a Compare April 9, 2026 11:50
@ShahakShama ShahakShama force-pushed the shahak/style-guide-remove-reexports branch from bb4ea3e to 79bef09 Compare April 9, 2026 12:12
@ShahakShama ShahakShama force-pushed the shahak/style-guide-remove-track-caller branch from 7d46d5a to 2fc5010 Compare April 9, 2026 12:12
@ShahakShama ShahakShama force-pushed the shahak/style-guide-remove-reexports branch from 79bef09 to 3f0e80c Compare April 9, 2026 12:15
@ShahakShama ShahakShama force-pushed the shahak/style-guide-remove-track-caller branch from 2fc5010 to 382803b Compare April 9, 2026 12:15
@ShahakShama ShahakShama force-pushed the shahak/style-guide-remove-track-caller branch from 382803b to c69c5c2 Compare April 13, 2026 10:51
@ShahakShama ShahakShama force-pushed the shahak/style-guide-remove-reexports branch from 8242310 to d494baa Compare April 15, 2026 05:53
@ShahakShama ShahakShama force-pushed the shahak/style-guide-remove-track-caller branch from c69c5c2 to 4d9ef2d Compare April 15, 2026 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants