remove track_caller sentence#13267
remove track_caller sentence#13267ShahakShama wants to merge 1 commit intoshahak/style-guide-remove-reexportsfrom
Conversation
16db7bb to
6cd6c43
Compare
3c533d0 to
3919551
Compare
Stavbe
left a comment
There was a problem hiding this comment.
@Stavbe made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on ShahakShama).
style.md line 69 at r1 (raw file):
- Resolving merge conflicts: AI tends sometimes to just pick our changes without thinking about it. ## Testing
Don't we want to put here the naming convention for tests?
ShahakShama
left a comment
There was a problem hiding this comment.
@ShahakShama made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on Stavbe).
style.md line 69 at r1 (raw file):
Previously, Stavbe wrote…
Don't we want to put here the naming convention for tests?
Yes. Later PR in this stack :)
ShahakShama
left a comment
There was a problem hiding this comment.
@ShahakShama made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on Stavbe).
style.md line 69 at r1 (raw file):
Previously, ShahakShama wrote…
Yes. Later PR in this stack :)
Stavbe
left a comment
There was a problem hiding this comment.
@Stavbe reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ShahakShama).
3919551 to
4f1503e
Compare
6cd6c43 to
21ed7cb
Compare
4f1503e to
dcc3953
Compare
21ed7cb to
10bebc8
Compare
10bebc8 to
524983a
Compare
dcc3953 to
34ae200
Compare
524983a to
bb4ea3e
Compare
34ae200 to
7d46d5a
Compare
bb4ea3e to
79bef09
Compare
7d46d5a to
2fc5010
Compare
79bef09 to
3f0e80c
Compare
2fc5010 to
382803b
Compare
382803b to
c69c5c2
Compare
8242310 to
d494baa
Compare
c69c5c2 to
4d9ef2d
Compare
Note
Low Risk
Low risk documentation-only change that removes a single testing recommendation; no code or behavior changes.
Overview
Removes the
#[track_caller]recommendation from the Testing section instyle.md, leaving the remaining guidance on writing debuggable assertions and structuring tests unchanged.Written by Cursor Bugbot for commit dcc3953. This will update automatically on new commits. Configure here.