add section on expect vs allow#13626
Open
ShahakShama wants to merge 1 commit intoshahak/delete_combinators_sectionfrom
Open
add section on expect vs allow#13626ShahakShama wants to merge 1 commit intoshahak/delete_combinators_sectionfrom
ShahakShama wants to merge 1 commit intoshahak/delete_combinators_sectionfrom
Conversation
This was referenced Mar 31, 2026
Collaborator
Author
This was referenced Mar 31, 2026
d1d0981 to
b398faf
Compare
7ef43a2 to
7d5213a
Compare
b398faf to
36ec1e4
Compare
7d5213a to
d9860c9
Compare
b852960 to
9e4a0b0
Compare
33332ed to
2eb38fc
Compare
9e4a0b0 to
f1bdadf
Compare
Stavbe
approved these changes
Apr 12, 2026
Contributor
Stavbe
left a comment
There was a problem hiding this comment.
@Stavbe reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ShahakShama).
Stavbe
approved these changes
Apr 12, 2026
Contributor
Stavbe
left a comment
There was a problem hiding this comment.
@Stavbe made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ShahakShama).
7a291b1 to
78f8f57
Compare
f1bdadf to
40b4301
Compare
40b4301 to
254218e
Compare
78f8f57 to
23275c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Low Risk
Low risk documentation-only change; no runtime behavior or APIs are modified.
Overview
Adds a new
style.mdguideline section recommending#[expect(...)]over#[allow(...)]for lint suppression, with a short rationale and example showing how#[expect]prevents stale suppressions.Written by Cursor Bugbot for commit d1d0981. This will update automatically on new commits. Configure here.