Skip to content

add section on expect vs allow#13626

Open
ShahakShama wants to merge 1 commit intoshahak/delete_combinators_sectionfrom
shahak/style-guide-expect-vs-allow
Open

add section on expect vs allow#13626
ShahakShama wants to merge 1 commit intoshahak/delete_combinators_sectionfrom
shahak/style-guide-expect-vs-allow

Conversation

@ShahakShama
Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama commented Mar 31, 2026

Note

Low Risk
Low risk documentation-only change; no runtime behavior or APIs are modified.

Overview
Adds a new style.md guideline section recommending #[expect(...)] over #[allow(...)] for lint suppression, with a short rationale and example showing how #[expect] prevents stale suppressions.

Written by Cursor Bugbot for commit d1d0981. This will update automatically on new commits. Configure here.

@ShahakShama ShahakShama requested a review from Stavbe March 31, 2026 14:20
@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

ShahakShama commented Mar 31, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ShahakShama ShahakShama force-pushed the shahak/style-guide-expect-vs-allow branch from d1d0981 to b398faf Compare April 9, 2026 10:28
@ShahakShama ShahakShama force-pushed the shahak/delete_combinators_section branch 2 times, most recently from 7ef43a2 to 7d5213a Compare April 9, 2026 11:50
@ShahakShama ShahakShama force-pushed the shahak/style-guide-expect-vs-allow branch from b398faf to 36ec1e4 Compare April 9, 2026 11:50
@ShahakShama ShahakShama force-pushed the shahak/delete_combinators_section branch from 7d5213a to d9860c9 Compare April 9, 2026 12:12
@ShahakShama ShahakShama force-pushed the shahak/style-guide-expect-vs-allow branch 3 times, most recently from b852960 to 9e4a0b0 Compare April 9, 2026 12:37
@ShahakShama ShahakShama force-pushed the shahak/delete_combinators_section branch from 33332ed to 2eb38fc Compare April 9, 2026 12:37
@ShahakShama ShahakShama force-pushed the shahak/style-guide-expect-vs-allow branch from 9e4a0b0 to f1bdadf Compare April 9, 2026 15:05
Copy link
Copy Markdown
Contributor

@Stavbe Stavbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stavbe reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ShahakShama).

Copy link
Copy Markdown
Contributor

@Stavbe Stavbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Stavbe made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ShahakShama).

@ShahakShama ShahakShama force-pushed the shahak/delete_combinators_section branch from 7a291b1 to 78f8f57 Compare April 13, 2026 10:51
@ShahakShama ShahakShama force-pushed the shahak/style-guide-expect-vs-allow branch from f1bdadf to 40b4301 Compare April 13, 2026 10:51
@ShahakShama ShahakShama force-pushed the shahak/style-guide-expect-vs-allow branch from 40b4301 to 254218e Compare April 15, 2026 05:53
@ShahakShama ShahakShama force-pushed the shahak/delete_combinators_section branch from 78f8f57 to 23275c8 Compare April 15, 2026 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants