Skip to content

starknet_committer: create storage tries concurrently#13359

Closed
nimrod-starkware wants to merge 1 commit intographite-base/13359from
nimrod/parallel-reads/storage-tries-concurrently
Closed

starknet_committer: create storage tries concurrently#13359
nimrod-starkware wants to merge 1 commit intographite-base/13359from
nimrod/parallel-reads/storage-tries-concurrently

Conversation

@nimrod-starkware
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware commented Mar 19, 2026

Note

Low Risk
Adds new (currently unused) concurrent code paths for building per-contract storage trie skeletons; no existing execution path is changed, so behavioral risk is low aside from potential compilation/trait-bound issues.

Overview
Introduces a concurrent implementation for building per-contract storage trie original skeletons by adding a TrieReadTask that implements StorageTask and a create_storage_tries_concurrently helper that batches tasks and runs them via AsyncStorage::gather.

Minor cleanup in AsyncStorage::gather moves the “ignore reads” comment to match the actual returned value; functional behavior is unchanged.

Written by Cursor Bugbot for commit 417396c. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@nimrod-starkware nimrod-starkware self-assigned this Mar 19, 2026
@nimrod-starkware nimrod-starkware marked this pull request as ready for review March 19, 2026 13:29
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/storage-tries-concurrently branch from 5f12deb to bc2921c Compare March 19, 2026 14:19
Copy link
Copy Markdown
Contributor Author

nimrod-starkware commented Mar 19, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/single-trie-refactor branch from 65935d0 to a1eff36 Compare March 22, 2026 06:28
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/storage-tries-concurrently branch 2 times, most recently from 35887d1 to 9da3d12 Compare March 22, 2026 08:06
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/single-trie-refactor branch 2 times, most recently from 12e7fcf to 54d9831 Compare March 25, 2026 11:36
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/storage-tries-concurrently branch 2 times, most recently from a1367a4 to e350d54 Compare March 25, 2026 11:47
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/single-trie-refactor branch from 2680a2d to c30ef75 Compare March 25, 2026 12:49
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/storage-tries-concurrently branch 2 times, most recently from 7262e62 to 69f2892 Compare March 25, 2026 13:31
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/single-trie-refactor branch from c30ef75 to fa975af Compare March 25, 2026 14:24
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/storage-tries-concurrently branch from 69f2892 to 288df13 Compare March 25, 2026 14:24
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants