starknet_committer: create storage tries concurrently#13359
Closed
nimrod-starkware wants to merge 1 commit intographite-base/13359from
Closed
starknet_committer: create storage tries concurrently#13359nimrod-starkware wants to merge 1 commit intographite-base/13359from
nimrod-starkware wants to merge 1 commit intographite-base/13359from
Conversation
5f12deb to
bc2921c
Compare
Contributor
Author
This was referenced Mar 19, 2026
65935d0 to
a1eff36
Compare
35887d1 to
9da3d12
Compare
12e7fcf to
54d9831
Compare
a1367a4 to
e350d54
Compare
2680a2d to
c30ef75
Compare
7262e62 to
69f2892
Compare
c30ef75 to
fa975af
Compare
69f2892 to
288df13
Compare
fa975af to
ff6bcbf
Compare
288df13 to
417396c
Compare
This was referenced Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Low Risk
Adds new (currently unused) concurrent code paths for building per-contract storage trie skeletons; no existing execution path is changed, so behavioral risk is low aside from potential compilation/trait-bound issues.
Overview
Introduces a concurrent implementation for building per-contract storage trie original skeletons by adding a
TrieReadTaskthat implementsStorageTaskand acreate_storage_tries_concurrentlyhelper that batches tasks and runs them viaAsyncStorage::gather.Minor cleanup in
AsyncStorage::gathermoves the “ignore reads” comment to match the actual returned value; functional behavior is unchanged.Written by Cursor Bugbot for commit 417396c. This will update automatically on new commits. Configure here.