Skip to content

starknet_committer: create storage tries concurrently based on wether storage is gatherable#13634

Open
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/as_gatherable_storagefrom
nimrod/parallel-reads/based-on-gatherable
Open

starknet_committer: create storage tries concurrently based on wether storage is gatherable#13634
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/as_gatherable_storagefrom
nimrod/parallel-reads/based-on-gatherable

Conversation

@nimrod-starkware
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware commented Mar 31, 2026

Note

Medium Risk
Introduces a new concurrent code path for reading storage tries, which can change execution order and stress underlying storage/task gathering behavior despite aiming to preserve results.

Overview
Storage trie reading can now run concurrently when the provided storage implements GatherableStorage (via Storage::as_gatherable_storage()), falling back to the existing sequential path otherwise.

To support this, read_forest/create_storage_tries switch from ReadOnlyStorage to Storage and add stricter Send/Sync/'static bounds on Layout::NodeLayout (and IndexDb’s hasher), enabling the new task-based concurrent traversal implementation.

Written by Cursor Bugbot for commit accaabe. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/based-on-gatherable branch from 977e597 to accaabe Compare March 31, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants