starknet_patricia_storage: cache reads with gatherable storage#13631
Open
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/gatherable-storagefrom
Open
Conversation
Contributor
Author
This was referenced Mar 31, 2026
fd2835b to
9ab4585
Compare
d34f602 to
7ce467f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Changes caching behavior by seeding
CachedStoragefrom concurrently gathered reads, which could impact performance/memory and cache correctness if assumptions about immutability/staleness are violated. Touches concurrency-related task execution plumbing but is scoped to read-path caching.Overview
CachedStoragenow participates inGatherableStorageand backfills its LRU from gathered reads. Runninggather()onCachedStoragecollects all key/value reads performed by concurrentStorageTasks (viarun_tasks_and_collect_reads) and inserts them into the cache for subsequent lookups.Separately, the default
GatherableStorage::gatherimplementation was adjusted to callrun_tasks_and_collect_reads(&*self, ...)and a comment typo was fixed.Written by Cursor Bugbot for commit 9ab4585. This will update automatically on new commits. Configure here.