Skip to content

starknet_patricia_storage: add as_gatherable_storage to storage trait#13633

Open
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/concurrentlyfrom
nimrod/parallel-reads/as_gatherable_storage
Open

starknet_patricia_storage: add as_gatherable_storage to storage trait#13633
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/concurrentlyfrom
nimrod/parallel-reads/as_gatherable_storage

Conversation

@nimrod-starkware
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware commented Mar 31, 2026

Note

Medium Risk
Introduces a new method on the core Storage trait and updates multiple backends/wrappers to implement it, which is a public API change that can cause downstream compile breaks. Runtime behavior is largely unchanged but trait-bound tightening ('static/ImmutableReadOnlyStorage) may restrict some generic usages.

Overview
Adds Storage::as_gatherable_storage to optionally downcast a mutable Storage into a GatherableStorage for running concurrent read tasks.

Updates AerospikeStorage, MdbxStorage, RocksDbStorage, NullStorage, and CachedStorage to return Some(self) and implement/propagate GatherableStorage, and tightens CachedStorage (and CLI CachedStorageArgs) generic bounds to require ImmutableReadOnlyStorage + 'static.

Written by Cursor Bugbot for commit 8d6b4d8. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/concurrently branch from 4df1263 to 99fe9ee Compare March 31, 2026 15:48
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/as_gatherable_storage branch from 9598038 to 8d6b4d8 Compare March 31, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants