starknet_patricia_storage: add as_gatherable_storage to storage trait#13633
Open
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/concurrentlyfrom
Open
Conversation
This was referenced Mar 31, 2026
Contributor
Author
4df1263 to
99fe9ee
Compare
9598038 to
8d6b4d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Introduces a new method on the core
Storagetrait and updates multiple backends/wrappers to implement it, which is a public API change that can cause downstream compile breaks. Runtime behavior is largely unchanged but trait-bound tightening ('static/ImmutableReadOnlyStorage) may restrict some generic usages.Overview
Adds
Storage::as_gatherable_storageto optionally downcast a mutableStorageinto aGatherableStoragefor running concurrent read tasks.Updates
AerospikeStorage,MdbxStorage,RocksDbStorage,NullStorage, andCachedStorageto returnSome(self)and implement/propagateGatherableStorage, and tightensCachedStorage(and CLICachedStorageArgs) generic bounds to requireImmutableReadOnlyStorage + 'static.Written by Cursor Bugbot for commit 8d6b4d8. This will update automatically on new commits. Configure here.