starknet_committer: create storage tries concurrently

[nimrod-starkware]

Note

Medium Risk
Introduces a new concurrent code path for building per-contract storage tries and tightens NodeLayout trait bounds (Send/Sync), which can affect implementors and has typical concurrency/correctness risks despite the new path currently being unused (dead_code).

Overview
Adds scaffolding to build per-contract storage trie original skeletons concurrently via ImmutableReadOnlyStorage::gather: introduces TrieReadTask implementing StorageTask and a new create_storage_tries_concurrently helper that fans out one task per contract and collects results.

Updates starknet_patricia::NodeLayout to require Send on NodeData and Send + Sync on SubTree to support cross-task execution.

^{Reviewed by Cursor Bugbot for commit 767c891. Bugbot is set up for automated code reviews on this repo. Configure here.}

[reviewable-StarkWare]

This change is 

[nimrod-starkware]

• starknet_committer: create storage tries concurrently based on wether storage is gatherable #13634 : 2 dependent PRs (#13695 , #13753 )
• starknet_patricia_storage: add as_gatherable_storage to storage trait #13633
• starknet_committer: create storage tries concurrently #13632 👈 (View in Graphite)
• starknet_patricia_storage: cache reads with gatherable storage #13631
• starknet_patricia_storage: redefine gatherable storage trait #13752
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ArielElp]

@ArielElp reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on nimrod-starkware).

---

crates/starknet_committer/src/db/trie_traversal.rs line 494 at r1 (raw file):

        Send + Sync,
    for<'b> <Layout as NodeLayout<'b, <Layout as NodeLayoutFor<StarknetStorageValue>>::DbLeaf>>::NodeData:
        Send,

Lose these bounds everywhere in this file and add them at the trait level in db_layout.rs, add Send on NodeData and Send+Sync on SubTree. A little less general but worth it IMO, we only use simple types here.

Code quote:

    for<'b> <Layout as NodeLayout<'b, <Layout as NodeLayoutFor<StarknetStorageValue>>::DbLeaf>>::SubTree:
        Send + Sync,
    for<'b> <Layout as NodeLayout<'b, <Layout as NodeLayoutFor<StarknetStorageValue>>::DbLeaf>>::NodeData:
        Send,

[nimrod-starkware]

@nimrod-starkware made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on ArielElp and nimrod-starkware).

---

crates/starknet_committer/src/db/trie_traversal.rs line 494 at r1 (raw file):

Previously, ArielElp wrote…

Lose these bounds everywhere in this file and add them at the trait level in db_layout.rs, add Send on NodeData and Send+Sync on SubTree. A little less general but worth it IMO, we only use simple types here.

Done.

[ArielElp]

@ArielElp reviewed 3 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on nimrod-starkware).

[cursor]

PR Summary

Medium Risk
Introduces concurrency-related trait bounds and a new GatherableStorage-driven task path for building storage tries, which may ripple to all NodeLayout implementers and affect compile-time and runtime threading assumptions.

Overview
Adds an (currently unused) concurrent pathway for building per-contract storage trie skeletons by introducing TrieReadTask and create_storage_tries_concurrently, designed to run via GatherableStorage::gather with per-task ReadsCollectorStorage snapshots.

Updates starknet_patricia::NodeLayout to be thread-safe (NodeData: Send, SubTree: Send + Sync) to support running trie traversal work across concurrent tasks.

^{Reviewed by Cursor Bugbot for commit 8cca25e. Bugbot is set up for automated code reviews on this repo. Configure here.}

[dorimedini-starkware]

@dorimedini-starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on nimrod-starkware).

---

crates/starknet_committer/src/db/trie_traversal.rs line 520 at r4 (raw file):

    <Layout as NodeLayoutFor<StarknetStorageValue>>::DbLeaf:
        HasStaticPrefix<KeyContext = ContractAddress>,
{

better to be consistent, at least in a single signature

Suggestion:

async fn create_storage_tries_concurrently<'a, S, Layout>(
    storage: &mut S,
    actual_storage_updates: &'a HashMap<ContractAddress, LeafModifications<StarknetStorageValue>>,
    original_contracts_trie_leaves: &HashMap<NodeIndex, ContractState>,
    warn_on_trivial_modifications: bool,
    storage_tries_sorted_indices: &'a HashMap<ContractAddress, SortedLeafIndices<'a>>,
) -> ForestResult<HashMap<ContractAddress, OriginalSkeletonTreeImpl<'a>>>
where
    S: ImmutableReadOnlyStorage,
    Layout: NodeLayoutFor<StarknetStorageValue> + Send + 'static,
    <Layout as NodeLayoutFor<StarknetStorageValue>>::DbLeaf:
        HasStaticPrefix<KeyContext = ContractAddress>,
{

[nimrod-starkware]

@nimrod-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware).

---

crates/starknet_committer/src/db/trie_traversal.rs line 520 at r4 (raw file):

Previously, dorimedini-starkware wrote…

better to be consistent, at least in a single signature

Done.

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on nimrod-starkware).

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on nimrod-starkware).

[nimrod-starkware]

@nimrod-starkware reviewed all commit messages.
Reviewable status: 3 of 4 files reviewed, all discussions resolved.

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on nimrod-starkware).