ENG-1330: zod schema for discourse relations

[sid597]

https://www.loom.com/share/ea503e1ac69d4a8a8be222770058e3bf

Summary by CodeRabbit

• New Features
  • A new Relations management feature is now available in global settings. Users can define and configure custom relations with properties including labels, source/destination specifications, complement settings, conditional logic rules, and node positioning data. This enables sophisticated relation management and supports complex discourse configurations for advanced platform control.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[linear]

ENG-1330 Add zod Schema for the discourse relations

[supabase]

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[supabase]

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[sid597]

• ENG-1345: Modify existing RoamJS component onChange to also change props #745 : 2 dependent PRs (#684 , #688 )
• ENG-1190 Replace existing roam-js components with blockProp based ones #689
• ENG-1188: prod: pull watchers for prop based settings #682
• ENG-1187: Prod: Implement get and set for block prop based settings #669
• ENG-1189: Prod: Init block prop based schema #666
• ENG-1330: zod schema for discourse relations #719 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[sid597]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request adds a new Relations feature to the GlobalSettings schema by introducing three Zod schemas (Triple, RelationCondition, DiscourseRelation) and extending GlobalSettingsSchema with a Relations field. The example file demonstrates the structure with two sample relation definitions containing metadata and conditional triples.

Changes

Cohort / File(s)

Summary

Schema and Example Data for Relations Feature apps/roam/src/components/settings/utils/zodSchema.ts, apps/roam/src/components/settings/utils/zodSchema.example.ts

Introduces three new Zod schemas: TripleSchema (tuple of three strings), RelationConditionSchema (with triples and nodePositions), and DiscourseRelationSchema (with id, label, source, destination, complement, triples, and ifConditions). Extends GlobalSettingsSchema with a Relations array field. Example file populates Relations with two sample relations (relation-uid-1 "Informs" and relation-uid-2 "Supports") including their metadata and conditional configuration. Exports new TypeScript types: Triple, RelationCondition, and DiscourseRelationSettings.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• ENG-1105: zod schema for all the settings #664: Modifies the same GlobalSettings schema files; this PR extends the schema by adding the Relations field and supporting schemas for managing discourse relations.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title clearly and specifically identifies the main change: adding a zod schema for discourse relations, which is directly reflected in the file modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@apps/roam/src/components/settings/utils/zodSchema.ts`:
- Around line 139-154: The conversion currently drops relation metadata arrays:
STANDARD_ROLES (conceptConversion.ts) filters out triples and ifConditions and
discourseRelationSchemaToLocalConcept maps relation.triples to only the first
element via relation.triples.map((t) => t[0]), causing silent data loss when
producing LocalConceptDataInput for local_reference_content; update the
conversion to preserve the full arrays (include triples and ifConditions) by
adding them to the allowed output shape or extending LocalConceptDataInput to
accept a relations metadata field, remove or extend STANDARD_ROLES so it no
longer strips triples/ifConditions, and ensure
discourseRelationSchemaToLocalConcept copies relation.triples and
relation.ifConditions intact (instead of extracting only t[0]) so serialized
storage retains the full structures.

[mdroidian]

Since these triples are just conditions I wonder if we could we reuse Conditions and/or ConditionSchema?