ENG-1225: Discourse node migration simple settings by sid597 · Pull Request #696 · DiscourseGraphs/discourse-graph

sid597 · 2026-01-14T09:00:52Z

https://www.loom.com/share/9aa6f5f8815e41de92f21e14f7f5f855

demo video

changes done to following settings

"Key Image" — DiscourseNodeCanvasSettings.tsx

"Embedding Block Ref" — DiscourseNodeSuggestiveRules.tsx

"First Child" — DiscourseNodeSuggestiveRules.tsx

"Description" — NodeConfig.tsx

"Shortcut" — NodeConfig.tsx

"Tag" — NodeConfig.tsx

"Graph Overview" — NodeConfig.tsx

ENG-1225: Discourse node migration

Migrate personal settings text inputs

remove unnecessary checks zod takes care

migrate attributes overlay and suggestive rules

Summary by CodeRabbit

Refactor
- Migrated all settings storage from global to personal user-scoped configuration
- Added real-time validation and error message feedback for node configuration settings, including tags and format specifications
- Refactored component interfaces to reduce dependencies and improve maintainability
- Standardized keyboard shortcut configuration across menu trigger features

_{✏️ Tip: You can customize this high-level summary in your review settings.}

linear · 2026-01-14T09:00:55Z

ENG-1225 Discourse node: migrate settings

supabase · 2026-01-14T09:00:58Z

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

sid597 · 2026-01-14T09:01:27Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

ENG-1225: Discourse node migration simple settings #696 : 2 dependent PRs (#697 , #764 ) 👈 (View in Graphite)
ENG-1273: Migrate small personal settings #691
ENG-1272 Migrate all small global settings components #688 : 1 other dependent PR (#690 )
ENG-1345: Modify existing RoamJS component onChange to also change props #745 : 1 other dependent PR (#684 )
ENG-1190 Replace existing roam-js components with blockProp based ones #689
ENG-1188: prod: pull watchers for prop based settings #682
ENG-1187: Prod: Implement get and set for block prop based settings #669
ENG-1189: Prod: Init block prop based schema #666
ENG-1330: zod schema for discourse relations #719
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

devin-ai-integration

Devin Review found 1 potential issue.

View issue and 6 additional flags in Devin Review.

apps/roam/src/components/settings/DiscourseNodeSuggestiveRules.tsx

devin-ai-integration

Devin Review found 1 new potential issue.

View issue and 20 additional flags in Devin Review.

apps/roam/src/components/settings/NodeConfig.tsx

devin-ai-integration

Devin Review found 1 new potential issue.

View issue and 24 additional flags in Devin Review.

apps/roam/src/components/settings/ExportSettings.tsx

devin-ai-integration

Devin Review found 1 new potential issue.

View 23 additional findings in Devin Review.

apps/roam/src/components/settings/DiscourseNodeCanvasSettings.tsx

devin-ai-integration

Devin Review found 1 new potential issue.

View 22 additional findings in Devin Review.

apps/roam/src/components/settings/components/BlockPropSettingPanels.tsx

sid597 · 2026-02-10T09:33:15Z

apps/roam/src/components/settings/utils/zodSchema.ts

  overlay: stringWithDefault(""),
  index: IndexSchema.nullable().optional(),
-  suggestiveRules: SuggestiveRulesSchema.nullable().optional(),
-  embeddingRef: stringWithDefault(""),


Wrong, we don't want these to exist on top level they have to be under suggestiveRules schema only

sid597 · 2026-02-10T09:34:26Z

apps/roam/src/components/settings/components/BlockPropSettingPanels.tsx

  const [value, setValue] = useState(
    () => defaultValue ?? getter(settingKeys) ?? "",
  );
+  const error = validate?.(value);


Some discourse node text panels need validation logic adding support for that

I wonder if validate could be renamed to better reflect its return value. Right now it reads like it returns a boolean, but it actually returns an error message (string) or undefined when valid. Something like getValidationError / getErrorMessage would make that clearer, and adding a

type ValidationError = string; type Validator<T> = (value: T) => ValidationError | undefined;

type alias would lock in the intent.

sid597 · 2026-02-10T09:34:55Z

apps/roam/src/components/settings/components/BlockPropSettingPanels.tsx

+  settingKeys: string[];
+};
+
+export const DiscourseNodeTextPanel = ({


new panels for discourseNode usage

mdroidian

Everything was generally good until NodeConfig.tsx. There are a bunch of changes in there that don't really make sense to me. I'm not sure if they were stylistic choices or if somehow they related to settings in props.

Could you do a quick video explaining the changes.

Also, make sure to format all files with prettier and make sure there are no lint errors in your new code before sending for re-review.

mdroidian · 2026-02-11T03:32:46Z

apps/roam/src/components/settings/components/BlockPropSettingPanels.tsx

  onChange?: (values: string[]) => void;
 } & RoamBlockSyncProps;

+const DEBOUNCE_MS = 500;


Let's cut this in half.

mdroidian · 2026-02-11T03:38:24Z

apps/roam/src/components/settings/components/BlockPropSettingPanels.tsx

  const [value, setValue] = useState(
    () => defaultValue ?? getter(settingKeys) ?? "",
  );
+  const error = validate?.(value);


I wonder if validate could be renamed to better reflect its return value. Right now it reads like it returns a boolean, but it actually returns an error message (string) or undefined when valid. Something like getValidationError / getErrorMessage would make that clearer, and adding a

type ValidationError = string; type Validator<T> = (value: T) => ValidationError | undefined;

type alias would lock in the intent.

mdroidian · 2026-02-11T03:48:29Z

apps/roam/src/components/settings/DiscourseNodeCanvasSettings.tsx

+        onChange={(checked) => {
+          setIsKeyImage(checked);
+          if (checked && !keyImageOption) setKeyImageOption("first-image");
+          setInputSetting({


Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the void operator.eslint@typescript-eslint/no-floating-promises

mdroidian · 2026-02-11T03:49:31Z

apps/roam/src/components/settings/DiscourseNodeCanvasSettings.tsx

        onChange={(e) => {
-          const target = e.target as HTMLInputElement;
-          setKeyImageOption(target.value);
+          const value = (e.target as HTMLInputElement).value;


What was the purpose of this change?

mdroidian · 2026-02-11T03:53:15Z

apps/roam/src/components/settings/NodeConfig.tsx

-  const graphOverviewUid = getUid("Graph Overview");
  const specificationUid = getUid("Specification");
  const indexUid = getUid("Index");
+  const overlayUid = getUid("Overlay");


What is the purpose of re-ordering these?

mdroidian · 2026-02-11T03:56:44Z

apps/roam/src/components/settings/NodeConfig.tsx

        return;
      }
-      const cleanTag = getCleanTagText(tag);
+      const cleanTag = getCleanTagText(tagValue);


This value is now generated from a different function/mechanism than before this PR. Could you explain why this change was made and how it relates to the new schema?

mdroidian · 2026-02-11T03:58:21Z

apps/roam/src/index.ts

@@ -42,7 +42,6 @@ import {
  DISALLOW_DIAGNOSTICS,
 } from "./data/userSettings";
 // import { initSchema } from "./components/settings/utils/init";


mdroidian · 2026-02-11T04:00:54Z

And make sure to zoom in ~50% when doing loom videos, you have a very large monitor 🙂

sid597 mentioned this pull request Jan 14, 2026

ENG-1273: Migrate small personal settings #691

Open

sid597 changed the title ~~ENG-1225: Discourse node migration~~ ENG-1225: Discourse node migration simple settings Jan 14, 2026

sid597 marked this pull request as ready for review January 14, 2026 09:02

This was referenced Jan 14, 2026

ENG-1280 Discourse node: Query builder and editor component for block props #697

Closed

global left sidebar settings #704

Closed

migrate personal left sidebar setting #705

Closed

sid597 force-pushed the eng-1225-discourse-node-migrate-settings-prod branch from 3ac2996 to d549f8d Compare January 17, 2026 18:16

sid597 force-pushed the eng-1273-migrate-all-small-personal-settings branch from a82cfaf to bc0de10 Compare January 17, 2026 18:16

sid597 force-pushed the eng-1225-discourse-node-migrate-settings-prod branch from d549f8d to 78b7dbb Compare January 18, 2026 05:25

sid597 force-pushed the eng-1273-migrate-all-small-personal-settings branch from bc0de10 to 57abc42 Compare January 18, 2026 05:25

sid597 force-pushed the eng-1225-discourse-node-migrate-settings-prod branch from 78b7dbb to d66fa03 Compare January 19, 2026 04:51

sid597 force-pushed the eng-1273-migrate-all-small-personal-settings branch from 57abc42 to 7ead54e Compare January 19, 2026 04:51

sid597 force-pushed the eng-1225-discourse-node-migrate-settings-prod branch from d66fa03 to cb22590 Compare January 19, 2026 05:01

sid597 force-pushed the eng-1273-migrate-all-small-personal-settings branch from 490810f to 8dc5276 Compare January 19, 2026 06:03

sid597 force-pushed the eng-1225-discourse-node-migrate-settings-prod branch from cb22590 to 78abef0 Compare January 19, 2026 06:03

sid597 force-pushed the eng-1273-migrate-all-small-personal-settings branch from 8dc5276 to 8286d6b Compare January 19, 2026 06:34

sid597 force-pushed the eng-1225-discourse-node-migrate-settings-prod branch from 78abef0 to 3966245 Compare January 19, 2026 06:34

This was referenced Jan 19, 2026

port query settings #717

Closed

port discourse node config #718

Closed

sid597 force-pushed the eng-1273-migrate-all-small-personal-settings branch from 8286d6b to 78e8311 Compare January 20, 2026 16:06

sid597 force-pushed the eng-1225-discourse-node-migrate-settings-prod branch from 3966245 to 7015148 Compare January 20, 2026 16:06

sid597 changed the base branch from eng-1273-migrate-all-small-personal-settings to graphite-base/696 January 28, 2026 21:16

sid597 force-pushed the eng-1225-discourse-node-migrate-settings-prod branch from 7015148 to ecdee21 Compare January 29, 2026 11:34

sid597 force-pushed the graphite-base/696 branch from 78e8311 to 938f6aa Compare January 29, 2026 11:34

sid597 changed the base branch from graphite-base/696 to eng-1273-migrate-all-small-personal-settings January 29, 2026 11:34

devin-ai-integration bot reviewed Jan 29, 2026

View reviewed changes

apps/roam/src/components/settings/DiscourseNodeSuggestiveRules.tsx Outdated Show resolved Hide resolved

sid597 force-pushed the eng-1225-discourse-node-migrate-settings-prod branch from ecdee21 to 96f4575 Compare January 30, 2026 06:10

devin-ai-integration bot reviewed Feb 3, 2026

View reviewed changes

apps/roam/src/components/settings/NodeConfig.tsx Show resolved Hide resolved

sid597 force-pushed the eng-1225-discourse-node-migrate-settings-prod branch from a449a73 to 84aa5ac Compare February 3, 2026 21:53

graphite-app bot reviewed Feb 3, 2026

View reviewed changes

apps/roam/src/components/settings/NodeConfig.tsx Show resolved Hide resolved

sid597 force-pushed the eng-1273-migrate-all-small-personal-settings branch from 88d4ff5 to f5d0a0a Compare February 4, 2026 17:56

sid597 force-pushed the eng-1225-discourse-node-migrate-settings-prod branch from 84aa5ac to 8ad6b12 Compare February 4, 2026 17:56

devin-ai-integration bot reviewed Feb 4, 2026

View reviewed changes

apps/roam/src/components/settings/ExportSettings.tsx Outdated Show resolved Hide resolved

sid597 changed the base branch from eng-1273-migrate-all-small-personal-settings to graphite-base/696 February 7, 2026 18:29

sid597 force-pushed the graphite-base/696 branch from f5d0a0a to 7f28c8c Compare February 9, 2026 09:46

sid597 force-pushed the eng-1225-discourse-node-migrate-settings-prod branch from 8ad6b12 to 29b1281 Compare February 9, 2026 09:46

sid597 changed the base branch from graphite-base/696 to eng-1273-migrate-all-small-personal-settings February 9, 2026 09:47

devin-ai-integration bot reviewed Feb 9, 2026

View reviewed changes

apps/roam/src/components/settings/DiscourseNodeCanvasSettings.tsx Outdated Show resolved Hide resolved

devin-ai-integration bot reviewed Feb 9, 2026

View reviewed changes

apps/roam/src/components/settings/components/BlockPropSettingPanels.tsx Show resolved Hide resolved

sid597 added 5 commits February 10, 2026 13:16

ENG-1225: Discourse node migration

b933056

Migrate personal settings text inputs

988dd6e

remove unnecessary checks zod takes care

ad0ba6b

restack and fix unnecessary changes

5ef67ad

fix, bug fixes, updates

62b37a6

sid597 changed the base branch from eng-1273-migrate-all-small-personal-settings to graphite-base/696 February 10, 2026 07:46

remove unused

ee13988

sid597 force-pushed the eng-1225-discourse-node-migrate-settings-prod branch from fd062f4 to ee13988 Compare February 10, 2026 08:28

sid597 changed the base branch from graphite-base/696 to eng-1273-migrate-all-small-personal-settings February 10, 2026 08:29

sid597 requested a review from mdroidian February 10, 2026 09:31

sid597 commented Feb 10, 2026

View reviewed changes

mdroidian requested changes Feb 11, 2026

View reviewed changes

This was referenced Feb 11, 2026

ENG-1280: Port Discourse node: Query builder and editor component for block props #764

Open

ENG-1291: Port discourse node specification #765

Open

ENG-1290: Port discourse node config panel #769

Open

Conversation

sid597 commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

linear bot commented Jan 14, 2026

Uh oh!

supabase bot commented Jan 14, 2026

Uh oh!

sid597 commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mdroidian left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mdroidian commented Feb 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sid597 commented Jan 14, 2026 •

edited

Loading

sid597 commented Jan 14, 2026 •

edited

Loading