ENG-1290: Port discourse node config panel by sid597 · Pull Request #769 · DiscourseGraphs/discourse-graph

sid597 · 2026-02-12T09:13:47Z

https://www.loom.com/share/09868acba4424e28b0369c96104dbd3d

Summary by CodeRabbit

Bug Fixes
- Improved relation configuration saving with enhanced block structure and data persistence.
- Fixed initialization flow to correctly map and reconcile relation keys during settings setup.
- Enhanced configuration panel refresh to properly display saved relation settings.

linear · 2026-02-12T09:13:49Z

ENG-1290 Port Discourse node config panels

supabase · 2026-02-12T09:13:54Z

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

sid597 · 2026-02-12T09:14:10Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

ENG-1290: Port discourse node config panel #769 👈 (View in Graphite)
ENG-1291: Port discourse node specification #765
ENG-1280: Port Discourse node: Query builder and editor component for block props #764
ENG-1225: Discourse node migration simple settings #696 : 1 other dependent PR (#697 )
ENG-1273: Migrate small personal settings #691
ENG-1272 Migrate all small global settings components #688 : 1 other dependent PR (#690 )
ENG-1345: Modify existing RoamJS component onChange to also change props #745 : 1 other dependent PR (#684 )
ENG-1190 Replace existing roam-js components with blockProp based ones #689
ENG-1188: prod: pull watchers for prop based settings #682
ENG-1187: Prod: Implement get and set for block prop based settings #669
ENG-1189: Prod: Init block prop based schema #666
ENG-1330: zod schema for discourse relations #719
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

devin-ai-integration

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 6 additional findings.

sid597 · 2026-02-12T09:36:00Z

@coderabbitai full review

coderabbitai · 2026-02-12T09:36:08Z

✅ Actions performed

Full review triggered.

coderabbitai · 2026-02-12T09:41:34Z

📝 Walkthrough

Walkthrough

Modifies the Discourse relation configuration panel to support asynchronous block updates and saves computed relation data to global settings. Concurrently refactors initialization logic to reconcile placeholder relation keys with actual block UIDs and updates the block property accessor signature.

Changes

Cohort / File(s)	Summary
Relation Config Panel `apps/roam/src/components/settings/DiscourseRelationConfigPanel.tsx`	Restructures save flow to wrap state updates in async IIFE with setTimeout; rebuilds block construction logic to assemble "And" blocks with nested relation structures and node positions; introduces extraction and persistence of ifConditions and relation metadata to global settings via setGlobalSetting.
Settings Initialization & Reconciliation `apps/roam/src/components/settings/utils/init.ts`	Introduces new reconcileRelationKeys function to map placeholder relation keys to actual block UIDs discovered in grammar/relations blocks; updates initializeSettingsBlockProps signature to accept pageUid parameter; extends initialization flow to invoke reconciliation logic for global relations.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

PR #669: Modifies relations defaults/schema and block-prop accessors within settings plumbing, with direct usage in the init.ts changes and setGlobalSetting calls in the component.
PR #666: Changes settings initialization logic in init.ts including initializeSettingsBlockProps flow and global relation key handling, overlapping with the reconciliation refactoring in this PR.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'ENG-1290: Port discourse node config panel' directly reflects the main changes: porting/refactoring the DiscourseRelationConfigPanel component with new async state management and block structure logic.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@apps/roam/src/components/settings/DiscourseRelationConfigPanel.tsx`:
- Around line 572-712: Wrap the async IIFE passed to setTimeout in a
try/catch/finally: inside try keep the existing sequence (setInputSetting,
updateBlock, createBlock, saveCyToElementRef, deleteBlock/createBlock loops,
setGlobalSetting, back()); in catch log/report the error (e.g., console.error or
show a user-facing toast) so failures from deleteBlock/createBlock/etc. are
surfaced; in finally ensure UI state is restored (reset any loading flags like
setLoading(false) if used) and still call back() or otherwise enable navigation
so the user is not stuck; locate the IIFE around symbols setInputSetting,
deleteBlock, createBlock, setGlobalSetting, and back to apply the change.

🧹 Nitpick comments (1)

apps/roam/src/components/settings/DiscourseRelationConfigPanel.tsx (1)

576-596: Unawaited setInputSetting / updateBlock calls in an otherwise await-ed flow.

These calls are fire-and-forget while the rest of the save flow (lines 667–676) carefully awaits block mutations. If any of these writes fail silently or race with the createBlock at line 601 (which also targets rootUid), the saved state could be inconsistent. Consider awaiting them for predictable ordering, especially since you're already in an async context.

♻️ Suggested change

-                  setInputSetting({
+                  await setInputSetting({
                     blockUid: rootUid,
                     key: "source",
                     value: source,
                   });
-                  setInputSetting({
+                  await setInputSetting({
                     blockUid: rootUid,
                     key: "destination",
                     value: destination,
                     index: 1,
                   });
-                  setInputSetting({
+                  await setInputSetting({
                     blockUid: rootUid,
                     key: "complement",
                     value: complement,
                     index: 2,
                   });
-                  updateBlock({
+                  await updateBlock({
                     uid: rootUid,
                     text: label,
                   });

apps/roam/src/components/settings/DiscourseRelationConfigPanel.tsx

mdroidian

Most of the audio on the loom is inaudible. Be sure to quickly check the looms/audio before triggering reviews.

mdroidian · 2026-02-13T20:24:41Z

apps/roam/src/components/settings/utils/init.ts

+  }
+
+  if (changed) {
+    setBlockProps(globalBlockUid, { Relations: reconciledRelations }, false);


Object Literal Property name Relations must match one of the following formats: camelCaseeslint@typescript-eslint/naming-convention

This was referenced Feb 12, 2026

ENG-1280: Port Discourse node: Query builder and editor component for block props #764

Open

ENG-1291: Port discourse node specification #765

Open

sid597 marked this pull request as ready for review February 12, 2026 09:14

devin-ai-integration bot reviewed Feb 12, 2026

View reviewed changes

coderabbitai bot reviewed Feb 12, 2026

View reviewed changes

apps/roam/src/components/settings/DiscourseRelationConfigPanel.tsx Show resolved Hide resolved

ENG-1290: Port discourse node config panel

4e3f7d6

sid597 force-pushed the eng-1290-port-discourse-node-config-panelsv0 branch from 42e81c7 to 4e3f7d6 Compare February 12, 2026 09:54

sid597 requested review from mdroidian and removed request for mdroidian February 12, 2026 09:55

fix bug

aeb08bf

sid597 requested a review from mdroidian February 13, 2026 16:23

mdroidian approved these changes Feb 13, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ENG-1290: Port discourse node config panel#769

ENG-1290: Port discourse node config panel#769
sid597 wants to merge 2 commits intoeng-1291-port-discourse-node-specificationv1from
eng-1290-port-discourse-node-config-panelsv0

sid597 commented Feb 12, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

linear bot commented Feb 12, 2026

Uh oh!

supabase bot commented Feb 12, 2026

Uh oh!

sid597 commented Feb 12, 2026

Uh oh!

devin-ai-integration bot left a comment

Uh oh!

sid597 commented Feb 12, 2026

Uh oh!

coderabbitai bot commented Feb 12, 2026

Uh oh!

coderabbitai bot commented Feb 12, 2026

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

mdroidian left a comment

Uh oh!

mdroidian Feb 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

sid597 commented Feb 12, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

linear bot commented Feb 12, 2026

Uh oh!

supabase bot commented Feb 12, 2026

Uh oh!

sid597 commented Feb 12, 2026

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

sid597 commented Feb 12, 2026

Uh oh!

coderabbitai bot commented Feb 12, 2026

Uh oh!

coderabbitai bot commented Feb 12, 2026

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mdroidian left a comment

Choose a reason for hiding this comment

Uh oh!

mdroidian Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sid597 commented Feb 12, 2026 •

edited by coderabbitai bot

Loading