ENG-1273: Migrate small personal settings by sid597 · Pull Request #691 · DiscourseGraphs/discourse-graph

sid597 · 2026-01-12T16:00:21Z

NOTE: No usage video I tested all these and they work. The video will not be helpful because not able to show the console logs in loom video.

Summary by CodeRabbit

Release Notes

Refactor
- Migrated settings to be personalized per user instead of applied globally, enabling individual control over features like Discourse Context Overlay, Suggestive Mode Overlay, Page Preview, Text Selection Popup, and sidebar behavior.
- Streamlined personal settings interface with consolidated UI components.
Documentation
- Added comprehensive migration guide documenting settings system updates.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

linear · 2026-01-12T16:00:24Z

ENG-1273 Migrate all small personal settings

supabase · 2026-01-12T16:00:26Z

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

sid597 · 2026-01-12T16:00:51Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

ENG-1225: Discourse node migration simple settings #696 : 2 dependent PRs (#697 , #764 )
ENG-1273: Migrate small personal settings #691 👈 (View in Graphite)
ENG-1272 Migrate all small global settings components #688 : 1 other dependent PR (#690 )
ENG-1345: Modify existing RoamJS component onChange to also change props #745 : 1 other dependent PR (#684 )
ENG-1190 Replace existing roam-js components with blockProp based ones #689
ENG-1188: prod: pull watchers for prop based settings #682
ENG-1187: Prod: Implement get and set for block prop based settings #669
ENG-1189: Prod: Init block prop based schema #666
ENG-1330: zod schema for discourse relations #719
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

sid597 · 2026-02-07T18:41:50Z

apps/roam/src/components/settings/HomePersonalSettings.tsx

+        settingKeys={["Discourse Context Overlay"]}
+        defaultValue={getSetting<boolean>("discourse-context-overlay", false)}
+        onChange={(checked) => {
+          void setSetting("discourse-context-overlay", checked);


Note we are using getSetting and setSetting from the extensionAPI, so when we use these panel we save to both the extensionApi and the blockProps.

mdroidian · 2026-02-09T02:58:42Z

NOTE: No usage video I tested all these and they work. The video will not be helpful because not able to show the console logs in loom video.

@sid597
Why couldn't you show the console logs in the video?

Alternatively, another way of showing would be to show the before and after. EG: if blocks, show the blocks being added/removed. If props, show the props before, and show the props after.

mdroidian

Looks good.

Sentence case for UI

Let's take this opportunity to change all settings to "Sentence case". The team made that call awhile ago but looks like some of these might not have been changed.

So lets change that before merge

Settings Values

And remember that we discussed the setting values to be consistent as well:

either "lower-with-dash" or "Sentence case like this"

I'm not sure if this is scheduled for another issue, just wanting to note it again here.

apps/roam/src/components/settings/HomePersonalSettings.tsx

apps/roam/src/components/settings/QuerySettings.tsx

sid597 · 2026-02-09T07:32:17Z

@mdroidian Found out why I was not able to show the console, it was because in loom I was sharing tab instead of whole screen, and each time I tested with tab the console does not appear in the video. Now I have shared the whole screen and here is the video:

https://www.loom.com/share/d523d30113d3409abc608bfe48a8ab84

sid597 · 2026-02-09T07:33:58Z

apps/roam/src/components/settings/components/BlockPropSettingPanels.tsx

  setFeatureFlag,
 } from "~/components/settings/utils/accessors";
 import type { FeatureFlags } from "~/components/settings/utils/zodSchema";



to test add the following code here:

import { getSetting } from "~/utils/extensionSettings"; // --- DEBUG: maps block prop path to extensionAPI.settings key --- const BLOCK_PROP_TO_EXT_API: Record<string, string> = { "Discourse Context Overlay": "discourse-context-overlay", "Suggestive Mode Overlay": "suggestive-mode-overlay", "Text Selection Popup": "text-selection-popup", "Disable Sidebar Open": "disable-sidebar-open", "Page Preview": "page-preview", "Hide Feedback Button": "hide-feedback-button", "Auto Canvas Relations": "auto-canvas-relations", "Overlay in Canvas": "discourse-context-overlay-in-canvas", "Streamline Styling": "streamline-styling", "Disable Product Diagnostics": "disallow-diagnostics", "Query > Hide Query Metadata": "hide-metadata", "Query > Default Page Size": "default-page-size", "Query > Query Pages": "query-pages", }; const debugLog = (panel: string, title: string, settingKeys: string[], blockPropValue: unknown) => { const path = settingKeys.join(" > "); const extApiKey = BLOCK_PROP_TO_EXT_API[path]; const extApiValue = extApiKey ? getSetting(extApiKey, "(not set)") : "(no extensionAPI mapping)"; console.log( `[${panel}] "${title}"`, `\n blockProp [${path}]:`, blockPropValue, `\n extensionAPI [${extApiKey || "?"}]:`, extApiValue, ); };

sid597 · 2026-02-09T07:37:20Z

apps/roam/src/components/settings/components/BlockPropSettingPanels.tsx

    setValue(checked);
    setter(settingKeys, checked);
    await syncFlagToBlock(checked);
    onChange?.(checked);


to test add the following line to all the base panels, you just have to change the name i.e replace the "FlagPanel" with corresponding panel name

setTimeout(() => debugLog("FlagPanel", title, settingKeys, getter(settingKeys)), 500);

sid597 · 2026-02-09T08:24:00Z

@mdroidian re requesting review even though its already approved, because there are many changes related to Sentence Case

devin-ai-integration

Devin Review found 2 new potential issues.

View 16 additional findings in Devin Review.

apps/roam/src/components/settings/GeneralSettings.tsx

apps/roam/src/components/settings/ExportSettings.tsx

sid597 · 2026-02-10T07:50:03Z

apps/roam/src/components/settings/ExportSettings.tsx

  return (
    <div className="flex flex-col gap-4 p-1">
+      {/* TODO: Titles kept as lowercase to match legacy readers in getExportSettings.ts.
+          Update titles to Sentence case once read side is migrated to block props. */}


Not using Sentence case for titles of these GlobalFlagPanel because call site will break

sid597 · 2026-02-10T07:50:23Z

apps/roam/src/components/settings/SuggestiveModeSettings.tsx

          panel={
            <div className="flex flex-col gap-4 p-1">
+              {/* TODO: Titles kept as Title Case to match legacy readers in getSuggestiveModeConfigSettings.ts.
+                  Update titles to Sentence case once read side is migrated to block props. */}


Not using Sentence case for titles of these GlobalFlagPanel because call site will break

sid597 · 2026-02-10T07:50:48Z

apps/roam/src/components/settings/GeneralSettings.tsx

  return (
    <div className="flex flex-col gap-4 p-1">
+      {/* TODO: Titles kept as legacy casing to match readers in discourseConfigRef.ts and initializeObserversAndListeners.ts.
+          Update titles to Sentence case once read side is migrated to block props. */}


Not using Sentence case for titles of these panels because call site will break

sid597 mentioned this pull request Jan 12, 2026

Migrate small personal settings #690

Closed

sid597 marked this pull request as ready for review January 12, 2026 16:02

This was referenced Jan 14, 2026

ENG-1225: Discourse node migration simple settings #696

Open

ENG-1280 Discourse node: Query builder and editor component for block props #697

Closed

global left sidebar settings #704

Closed

migrate personal left sidebar setting #705

Closed

sid597 force-pushed the eng-1273-migrate-all-small-personal-settings branch from a82cfaf to bc0de10 Compare January 17, 2026 18:16

sid597 force-pushed the eng-1272-migrate-all-small-global-settings-component branch 2 times, most recently from 9015611 to 16b26f7 Compare January 18, 2026 05:25

sid597 force-pushed the eng-1273-migrate-all-small-personal-settings branch from bc0de10 to 57abc42 Compare January 18, 2026 05:25

sid597 force-pushed the eng-1272-migrate-all-small-global-settings-component branch from 16b26f7 to dd2272b Compare January 19, 2026 04:51

sid597 force-pushed the eng-1273-migrate-all-small-personal-settings branch from 57abc42 to 7ead54e Compare January 19, 2026 04:51

sid597 force-pushed the eng-1272-migrate-all-small-global-settings-component branch from dd2272b to 92ea54b Compare January 19, 2026 05:01

sid597 force-pushed the eng-1273-migrate-all-small-personal-settings branch 2 times, most recently from 490810f to 8dc5276 Compare January 19, 2026 06:03

sid597 force-pushed the eng-1272-migrate-all-small-global-settings-component branch from 5a165ac to bed3149 Compare January 19, 2026 06:34

sid597 force-pushed the eng-1273-migrate-all-small-personal-settings branch from 8dc5276 to 8286d6b Compare January 19, 2026 06:34

This was referenced Jan 19, 2026

port query settings #717

Closed

port discourse node config #718

Closed

sid597 force-pushed the eng-1272-migrate-all-small-global-settings-component branch from bed3149 to d23e91a Compare January 20, 2026 16:06

sid597 force-pushed the eng-1273-migrate-all-small-personal-settings branch from f5d0a0a to 2a4faca Compare February 7, 2026 18:29

sid597 changed the base branch from graphite-base/691 to eng-1272-migrate-all-small-global-settings-component February 7, 2026 18:30

sid597 commented Feb 7, 2026

View reviewed changes

sid597 requested a review from mdroidian February 7, 2026 18:41

mdroidian approved these changes Feb 9, 2026

View reviewed changes

sid597 changed the base branch from eng-1272-migrate-all-small-global-settings-component to graphite-base/691 February 9, 2026 05:48

sid597 commented Feb 9, 2026

View reviewed changes

sid597 force-pushed the graphite-base/691 branch from fcaa6de to 0ef04ee Compare February 9, 2026 07:44

sid597 force-pushed the eng-1273-migrate-all-small-personal-settings branch from 2a4faca to 1a99b62 Compare February 9, 2026 07:44

sid597 changed the base branch from graphite-base/691 to eng-1272-migrate-all-small-global-settings-component February 9, 2026 08:21

sid597 requested a review from mdroidian February 9, 2026 08:24

devin-ai-integration bot reviewed Feb 9, 2026

View reviewed changes

apps/roam/src/components/settings/GeneralSettings.tsx Outdated Show resolved Hide resolved

apps/roam/src/components/settings/ExportSettings.tsx Outdated Show resolved Hide resolved

sid597 added 4 commits February 9, 2026 14:00

fix

2aeab68

port more simple components, revert git ignore

a10922f

restack

a15588e

Sentence case

7f28c8c

sid597 force-pushed the eng-1273-migrate-all-small-personal-settings branch from 69ffb18 to 7f28c8c Compare February 9, 2026 09:46

sid597 force-pushed the eng-1272-migrate-all-small-global-settings-component branch from 0ef04ee to 15f3a6b Compare February 9, 2026 09:46

revert sentence case for readers that use old style

2b100df

sid597 commented Feb 10, 2026

View reviewed changes

mdroidian approved these changes Feb 11, 2026

View reviewed changes

This was referenced Feb 11, 2026

ENG-1280: Port Discourse node: Query builder and editor component for block props #764

Open

ENG-1291: Port discourse node specification #765

Open

ENG-1290: Port discourse node config panel #769

Open

Conversation

sid597 commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Release Notes

Uh oh!

linear bot commented Jan 12, 2026

Uh oh!

supabase bot commented Jan 12, 2026

Uh oh!

sid597 commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sid597 Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

mdroidian commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mdroidian left a comment

Choose a reason for hiding this comment

Sentence case for UI

Settings Values

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sid597 commented Feb 9, 2026

Uh oh!

sid597 Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

sid597 Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

sid597 commented Feb 9, 2026

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sid597 Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

sid597 Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

sid597 Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sid597 commented Jan 12, 2026 •

edited

Loading

sid597 commented Jan 12, 2026 •

edited

Loading

mdroidian commented Feb 9, 2026 •

edited

Loading