-
Notifications
You must be signed in to change notification settings - Fork 4
ENG-1273: Migrate small personal settings #691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sid597
wants to merge
5
commits into
eng-1272-migrate-all-small-global-settings-component
Choose a base branch
from
eng-1273-migrate-all-small-personal-settings
base: eng-1272-migrate-all-small-global-settings-component
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,4 +37,4 @@ yarn-error.log* | |
|
|
||
| # Local development files | ||
| local/* | ||
| .cursor/debug.log | ||
| .cursor/debug.log | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,6 +14,8 @@ const DiscourseGraphHome = () => { | |
| const [isAlertOpen, setIsAlertOpen] = useState(false); | ||
| return ( | ||
| <div className="flex flex-col gap-4 p-1"> | ||
| {/* TODO: Titles kept as legacy casing to match readers in discourseConfigRef.ts and initializeObserversAndListeners.ts. | ||
| Update titles to Sentence case once read side is migrated to block props. */} | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not using Sentence case for titles of these panels because call site will break |
||
| <GlobalTextPanel | ||
| title="trigger" | ||
| description="The trigger to create the node menu." | ||
|
|
@@ -26,7 +28,7 @@ const DiscourseGraphHome = () => { | |
| <GlobalTextPanel | ||
| title="Canvas Page Format" | ||
| description="The page format for canvas pages" | ||
| settingKeys={["Canvas Page Format"]} | ||
| settingKeys={["Canvas page format"]} | ||
| defaultValue={settings.canvasPageFormat.value || DEFAULT_CANVAS_PAGE_FORMAT} | ||
| order={1} | ||
| uid={settings.canvasPageFormat.uid} | ||
|
|
@@ -35,7 +37,7 @@ const DiscourseGraphHome = () => { | |
| <FeatureFlagPanel | ||
| title="(BETA) Left Sidebar" | ||
| description="Whether or not to enable the left sidebar." | ||
| featureKey="Enable Left Sidebar" | ||
| featureKey="Enable left sidebar" | ||
| order={2} | ||
| uid={settings.leftSidebarEnabled.uid} | ||
| parentUid={settings.settingsUid} | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not using Sentence case for titles of these
GlobalFlagPanelbecause call site will break