-
Notifications
You must be signed in to change notification settings - Fork 615
[PWGHF,PWGJE] Unify and extend MC flags in candidate tables (3-prong, D*+) #11382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
O2 linter results: ❌ 81 errors, |
fgrosa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vkucera, see a few suggestions from my side below
fgrosa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vkucera thanks a lot! I still have a few comments (mainly for the beauty part). Once completed, I would also like to ask you to update the creators and tasks for the already existing tagging (e.g. for the D* the name of the flags changed with respect to the current version
O2Physics/PWGHF/TableProducer/candidateCreatorDstar.cxx
Lines 640 to 645 in f8f8fbc
| if (indexRecDstar > -1) { | |
| flagDstar = signDstar * (BIT(aod::hf_cand_dstar::DecayType::DstarToD0Pi)); | |
| } | |
| if (indexRecD0 > -1) { | |
| flagD0 = signD0 * (BIT(aod::hf_cand_dstar::DecayType::D0ToPiK)); | |
| } |
fgrosa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vkucera many thanks! It looks all good to me, except for one case (I hope I didn't miss anything else)
alibuild
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-approving on behalf of @vkucera.
Add support for flagging all needed decay channels.
Background:
Concept considerations:
FlagMcMatchRec,FlagMcMatchGen.FlagMcDecayChanRec,FlagMcDecayChanGen. (To be renamed.)int8_t), not as bitmaps.0indicates no match.Caveat:
TODO: Extend to other species.