Skip to content

Conversation

@vkucera
Copy link
Collaborator

@vkucera vkucera commented May 27, 2025

Add support for flagging all needed decay channels.

Background:

  • MC-based corrections require knowledge about other decay channels than the ones expected in the candidate reconstruction and selection.
  • Decay reconstruction flags used in the skim creator and decay matching flags used in the candidate creators are conceptually different. The former flags tag all decay hypotheses that satisfy selection conditions, the latter flags tag the actual decay channels.

Concept considerations:

  • Separate decay reconstruction flags and decay matching flags.
  • Enumerate all decay channels that need to be flagged for a given candidate table.
  • All MC matching is be done in the candidate creators.
  • Flags of main channels are stored in the existing columns: FlagMcMatchRec, FlagMcMatchGen.
  • Flags of resonant channels are stored in the existing columns: FlagMcDecayChanRec, FlagMcDecayChanGen. (To be renamed.)
  • Flags are stored as signed enumerator values (type int8_t), not as bitmaps.
    • 0 indicates no match.
    • Sign indicates particle/antiparticle.

Caveat:

  • Invalidation of flags in existing derived data.

TODO: Extend to other species.

@github-actions github-actions bot added the pwghf PWG-HF label May 27, 2025
@github-actions
Copy link

github-actions bot commented May 27, 2025

O2 linter results: ❌ 81 errors, ⚠️ 0 warnings, 🔕 5 disabled

@github-actions github-actions bot changed the title Unify and extend MC flags in candidate tables [PWGHF] Unify and extend MC flags in candidate tables May 27, 2025
Copy link
Collaborator

@fgrosa fgrosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vkucera, see a few suggestions from my side below

Copy link
Collaborator

@fgrosa fgrosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vkucera thanks a lot! I still have a few comments (mainly for the beauty part). Once completed, I would also like to ask you to update the creators and tasks for the already existing tagging (e.g. for the D* the name of the flags changed with respect to the current version

if (indexRecDstar > -1) {
flagDstar = signDstar * (BIT(aod::hf_cand_dstar::DecayType::DstarToD0Pi));
}
if (indexRecD0 > -1) {
flagD0 = signD0 * (BIT(aod::hf_cand_dstar::DecayType::D0ToPiK));
}
). Thanks!

@vkucera vkucera changed the title [PWGHF] Unify and extend MC flags in candidate tables [PWGHF] Unify and extend MC flags in candidate tables (3-prong, D*+) Jun 3, 2025
@vkucera vkucera changed the title [PWGHF] Unify and extend MC flags in candidate tables (3-prong, D*+) Unify and extend MC flags in candidate tables (3-prong, D*+) Jun 4, 2025
@github-actions github-actions bot changed the title Unify and extend MC flags in candidate tables (3-prong, D*+) [PWGHF,PWGJE] Unify and extend MC flags in candidate tables (3-prong, D*+) Jun 4, 2025
Copy link
Collaborator

@fgrosa fgrosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vkucera many thanks! It looks all good to me, except for one case (I hope I didn't miss anything else)

@vkucera vkucera enabled auto-merge (squash) June 4, 2025 14:55
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @vkucera.

@vkucera vkucera merged commit e2c77d4 into AliceO2Group:master Jun 4, 2025
18 of 19 checks passed
@vkucera vkucera deleted the mc-flags branch June 4, 2025 17:48
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Jun 11, 2025
hernasab pushed a commit to hernasab/O2Physics that referenced this pull request Jun 11, 2025
EmilGorm pushed a commit to EmilGorm/O2Physics that referenced this pull request Jun 12, 2025
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jun 12, 2025
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jul 16, 2025
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants