-
Notifications
You must be signed in to change notification settings - Fork 614
[PWGHF] Implement gen and reco MC matching for correlated bkg decays #11418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
O2 linter results: ❌ 8 errors, |
1c6ef78 to
c24e94d
Compare
|
ciao @Marcellocosti thanks a lot for this important development. I had a look at it and I tried to understand the logic you want to implement. I have left some comments here and there to understand if I get exactly what you mean, please let me know what you think. |
Please consider the following formatting changes to AliceO2Group#11418
Please consider the following formatting changes to AliceO2Group#11418
Please consider the following formatting changes to AliceO2Group#11418
Please consider the following formatting changes to AliceO2Group#11418
Please consider the following formatting changes to AliceO2Group#11418
|
Dear @vkucera, I implemented your comments and also changed the handling of the Dstar matching for the reconstructed to be similar to the generated candidates. Please let me know if I missed something! |
vkucera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @Marcellocosti for the great work!
…liceO2Group#11418) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
…liceO2Group#11418) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
| if (indexRec > -1) { | ||
| flag = sign * (isDplus ? DecayChannelMain::DplusToPiKK : DecayChannelMain::DsToPiKK); | ||
| if (arrayDaughters[0].has_mcParticle()) { | ||
| swapping = int8_t(std::abs(arrayDaughters[0].mcParticle().pdgCode()) == kPiPlus); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear @Marcellocosti (all code owners cc), shouldn't it be kKPlus instead of kPiPlus here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the decay is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But the expected order is defined as KKPi here in:
auto arrPdgDaughtersDToPiKK{std::array{+kKPlus, -kKPlus, +kPiPlus}};There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But the expected order is defined as KKPi here in:
auto arrPdgDaughtersDToPiKK{std::array{+kKPlus, -kKPlus, +kPiPlus}};
Indeed, if the
But is there any reason to define the expected order of prongs different from how they appear in the dedicated enum and its comment (link)? The way how it is implemented now requires checking the source code deeply (line which you quote), while the enum hints another expected order (very intuitive but wrong).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vkucera, no, I think that the arrPdgDaughtersDToPiKK in this context is not responsible for definition of expected order (?) What is really responsible is the r.h.s. of the
swapping = int8_t(std::abs(arrayDaughters[0].mcParticle().pdgCode()) == kPiPlus);
comparison, since precisely this line defines whether swapping flag will be 0 or 1.
…liceO2Group#11418) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
In this PR, the matching for the study of the correlated background decays implemented in the linked configuration script is implemented for 2-prong and 3-prong candidates both at reco and at gen level.
By now I keep the PR in draft mode as there are several debug prints for the checks on the matching I am performing and because I will need to digest the rearrangement of the MC flags proposed in the PR #11382 when merged. Nevertheless, a feedback on the general structure is more than welcome. Tagging @stefanopolitano for info.
The modifications to the D0 and D+ trees are for testing purposes.