[PWGHF] Refactor of charm resonances derived data creator #11447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
O2 linter results: ❌ 0 errors, |
github-actions
bot
changed the title
Please consider the following formatting changes to AliceO2Group#11447
Please consider the following formatting changes to AliceO2Group#11447
Please consider the following formatting changes to AliceO2Group#11447
Please consider the following formatting changes to AliceO2Group#11447
fgrosa
requested changes
Jun 3, 2025
Collaborator
fgrosa
left a comment
fgrosa
left a comment
There was a problem hiding this comment.
Hi @Luca610 many thanks for the developments! I agree to implement in a second PR the matching to the MC based on the central improvements for standard channels, in the meantime I have a few (mostly minor) comments. Once implemented, you can mark the PR as ready for review for me
Contributor
Author
|
Hi @fgrosa, |
Please consider the following formatting changes to AliceO2Group#11447
Luca610
requested review from
NicoleBastid,
apalasciano,
deepathoms,
fcatalan92,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli and
zhangbiao-phy
as code owners
fgrosa
approved these changes
Jun 3, 2025
jinhyunni
pushed a commit
to jinhyunni/O2Physics
that referenced
this pull request
Jun 11, 2025
…up#11447) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
hernasab
pushed a commit
to hernasab/O2Physics
that referenced
this pull request
Jun 11, 2025
…up#11447) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
EmilGorm
pushed a commit
to EmilGorm/O2Physics
that referenced
this pull request
Jun 12, 2025
…up#11447) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
prottayCMT
pushed a commit
to prottayCMT/O2Physics2024
that referenced
this pull request
Jun 12, 2025
…up#11447) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ddobrigk
pushed a commit
to ddobrigk/O2Physics
that referenced
this pull request
Jun 14, 2025
…up#11447) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
smaff92
pushed a commit
to smaff92/O2Physics
that referenced
this pull request
Jun 17, 2025
…up#11447) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
vkucera
reviewed
Jul 14, 2025
Comment on lines
-395
to
458
| for (int i = 0; i < 3; ++i) { | ||
| for (int i = 0; i < 3; ++i) { // o2-linter: disable=magic-number (loop on xyz) | ||
| candidateV0.mom[i] = candidateV0.momPos[i] + candidateV0.momNeg[i]; |
Collaborator
There was a problem hiding this comment.
Fix this by using RecoDecay::pVec.
ddobrigk
pushed a commit
to ddobrigk/O2Physics
that referenced
this pull request
Jul 16, 2025
…up#11447) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild
added a commit
to alibuild/O2Physics
that referenced
this pull request
Aug 11, 2025
…up#11447) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jloemker
pushed a commit
to jloemker/O2Physics
that referenced
this pull request
Nov 11, 2025
…up#11447) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the dataCreatorCharmResoReduced workflow adding the following features:
A refactor of MC matching functions will follow soon after the merge of PRs #11382 and #11418