APP-16462: Add DatasetType to dataset proto#851
Merged
Conversation
Adds a DatasetType enum (BINARY_DATA, SEQUENCE_DATA) and a `type` field to the Dataset message and CreateDatasetRequest. The new field on CreateDatasetRequest is `optional` so server code can distinguish "client didn't send a type" from "client explicitly sent BINARY_DATA". Prerequisite for the sequence training datasets work (APP-16329). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
Author
|
Noting that we are using |
vpandiarajan20
added
the
ready-for-protos
1 task
vpandiarajan20
removed
the
ready-for-protos
njooma
approved these changes
May 18, 2026
vpandiarajan20
added
the
ready-for-protos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
DatasetTypeenum (BINARY_DATA,SEQUENCE_DATA) to the dataset proto, plus:Dataset.typefield on theDatasetmessage (number 5)optional DatasetType typefield onCreateDatasetRequest(number 3)optionalonCreateDatasetRequest.typelets the server distinguish "client didn't send a type" from "client explicitly sent the zero value" — both currently map toBINARY_DATAfor backwards compatibility, but the explicit-unset signal is useful for telemetry and future behavior.Prerequisite for the sequence training datasets work tracked in epic APP-16329 — App-side handler changes follow in a separate PR once this lands and Go stubs are regenerated.
Test plan
Dataset.GetType()andCreateDatasetRequest.GetType()accessors exist with the expected types🤖 Generated with Claude Code