APP-16463: Add dataset_ids field to Sequence proto#852
Open
vpandiarajan20 wants to merge 2 commits into
Open
Conversation
vpandiarajan20
added
the
ready-for-protos
vpandiarajan20
added
ready-for-protos
Adds a repeated string dataset_ids field at number 10 on the Sequence
message. Membership of a sequence in one or more datasets is tracked
here so the inverse lookup ("which datasets is this sequence in?") is
trivial and cleanup on sequence deletion has no cascade work to do.
The corresponding add/remove RPCs (AddSequencesToDataset /
RemoveSequencesFromDataset) and the App-side storage changes follow
in separate PRs.
Prerequisite for the sequence training datasets work (APP-16329).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vpandiarajan20
force-pushed
the
APP-16463-sequence-dataset-ids-proto
branch
from
02de4b5 to
a936ef7
Compare
vpandiarajan20
removed
the
ready-for-protos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
repeated string dataset_ids = 10field to theSequencemessage. Membership of a sequence in one or more datasets is tracked on the sequence document.What's not in this PR
These are separate proto changes that follow once this lands:
AddSequencesToDataset/RemoveSequencesFromDatasetRPCs and request/response messages (APP-16464)SequencesByDatasetIDRPC (APP-16465)Test plan
DatasetIDs []stringto the Sequence struct and an index ondataset_ids🤖 Generated with Claude Code