Skip to content

starknet_os: import random EC point logic#14195

Open
dorimedini-starkware wants to merge 1 commit into
05-25-release_upgrade_rand_crate_versionfrom
05-25-starknet_os_import_random_ec_point_logic
Open

starknet_os: import random EC point logic#14195
dorimedini-starkware wants to merge 1 commit into
05-25-release_upgrade_rand_crate_versionfrom
05-25-starknet_os_import_random_ec_point_logic

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 25, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 25, 2026

PR Summary

Low Risk
Small refactor that centralizes hint logic; behavior should match prior inlined implementation if the shared helper is equivalent.

Overview
The CoreHint::RandomEcPoint Cairo1 path in the shared hint processor no longer inlines curve sampling and BETA; it delegates to cairo_lang_runner::casm_run::random_ec_point, still driven by get_rng() so OS runs stay deterministic with seeded randomness.

Unused imports are dropped in the aggregator and SNOS hint processors (cell_ref_to_relocatable, Rng where no longer needed).

Reviewed by Cursor Bugbot for commit 7e5e74b. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@nimrod-starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ArielElp and yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 05-25-release_upgrade_rand_crate_version branch from 6a94bb1 to c0150e2 Compare May 25, 2026 14:50
@dorimedini-starkware dorimedini-starkware force-pushed the 05-25-starknet_os_import_random_ec_point_logic branch 2 times, most recently from 4c3f35f to 7723ac2 Compare May 25, 2026 15:04
@dorimedini-starkware dorimedini-starkware force-pushed the 05-25-release_upgrade_rand_crate_version branch from c0150e2 to c7d12ae Compare May 25, 2026 15:04
@dorimedini-starkware dorimedini-starkware force-pushed the 05-25-release_upgrade_rand_crate_version branch from c7d12ae to fb6172a Compare May 25, 2026 15:09
@dorimedini-starkware dorimedini-starkware force-pushed the 05-25-starknet_os_import_random_ec_point_logic branch from 7723ac2 to 7e5e74b Compare May 25, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants