Skip to content

starknet_patricia: change test util random u256#14193

Open
dorimedini-starkware wants to merge 1 commit into
mainfrom
05-25-starknet_patricia_change_test_util_random_u256
Open

starknet_patricia: change test util random u256#14193
dorimedini-starkware wants to merge 1 commit into
mainfrom
05-25-starknet_patricia_change_test_util_random_u256

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@dorimedini-starkware dorimedini-starkware self-assigned this May 25, 2026
Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 25, 2026

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 25, 2026

Artifacts upload workflows:

@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review May 25, 2026 13:39
@cursor
Copy link
Copy Markdown

cursor Bot commented May 25, 2026

PR Summary

Low Risk
Test-only utility and dependency cleanup; production Patricia logic is unchanged aside from updated test expectations.

Overview
Reimplements get_random_u256 in Patricia test helpers using ethnum::U256 and rejection sampling (with a bit-length mask) instead of num-bigint, and drops num-bigint from starknet_patricia dependencies and its testing feature.

Because random state-diff generation still uses a fixed seed but the sampling algorithm changed, the random-case committer integration test’s expected contracts trie root was updated accordingly. starknet_os dev-dependencies now pull num-bigint from the workspace without enabling rand on that dev-dependency directly (the testing feature still wires num-bigint/rand where needed).

Reviewed by Cursor Bugbot for commit ac88b7c. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@nimrod-starkware reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ArielElp and yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 05-25-starknet_patricia_change_test_util_random_u256 branch from c99e594 to ac88b7c Compare May 25, 2026 14:50
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nimrod-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ArielElp and yoavGrs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants