release: upgrade rand crate version#14194
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR SummaryMedium Risk Overview Call sites are migrated to the 0.9 API: Production paths touched include mempool gap-account eviction ( Reviewed by Cursor Bugbot for commit fb6172a. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6a94bb1. Configure here.
nimrod-starkware
left a comment
There was a problem hiding this comment.
@nimrod-starkware reviewed 28 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on ArielElp, dorimedini-starkware, and yoavGrs).
crates/starknet_os/src/hints/hint_implementation/output.rs line 152 at r1 (raw file):
// Generate a cryptographically secure random seed. let mut random_bytes = [0u8; 32]; OsRng.try_fill_bytes(&mut random_bytes).expect("OS RNG should not fail");
Doesnt it work? (probably need to import different trait)
I see it here
Suggestion:
OsRng.fill_bytes(&mut random_bytes);c99e594 to
ac88b7c
Compare
c0150e2 to
c7d12ae
Compare
c7d12ae to
fb6172a
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware made 1 comment.
Reviewable status: 26 of 28 files reviewed, 1 unresolved discussion (waiting on ArielElp, nimrod-starkware, and yoavGrs).
crates/starknet_os/src/hints/hint_implementation/output.rs line 152 at r1 (raw file):
Previously, nimrod-starkware wrote…
Doesnt it work? (probably need to import different trait)
I see it here
that's the deterministic_rand crate, not sure what that is, but OsRng no longer has a fill_bytes. from the docstring:
/// It is possible that when used during early boot the first call to `OsRng`
/// will block until the system's RNG is initialised. It is also possible
/// (though highly unlikely) for `OsRng` to fail on some platforms, most
/// likely due to system mis-configuration.
///
/// After the first successful call, it is highly unlikely that failures or
/// significant delays will occur (although performance should be expected to
/// be much slower than a user-space
/// [PRNG](https://rust-random.github.io/book/guide-gen.html#pseudo-random-number-generators)).
nimrod-starkware
left a comment
There was a problem hiding this comment.
@nimrod-starkware reviewed 2 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ArielElp and yoavGrs).


No description provided.