Reduce session ping frequency from 30s to 1 hour#371
Merged
0pcom merged 1 commit intoskycoin:developfrom Apr 7, 2026
Merged
Conversation
The ping loop measures latency to DMSG servers for server selection. It is not a keepalive (yamux handles that). 30s was excessive, generating N_clients * N_servers debug log lines every 30 seconds. Changed to 5 minutes and lowered log level from Debug to Trace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pingSessionsLoopinterval from 30 seconds to 1 hourThe ping loop measures latency to DMSG servers for server selection. It is not a keepalive (yamux handles that). 30s was excessive, generating N_clients × N_servers debug log lines every 30 seconds. A visor with 3 DMSG clients connected to 6 servers produces 18 ping log lines every 30 seconds.
Test plan