Skip to content

Reduce session ping frequency from 30s to 1 hour #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0pcom merged 1 commit into from
Apr 7, 2026
Merged

Reduce session ping frequency from 30s to 1 hour #371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions pkg/dmsg/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,8 +527,11 @@ func (ce *Client) reconnectMissing(ctx context.Context) {
}

// pingSessionsLoop periodically pings all sessions to measure latency.
// The interval is 1 hour — this is for server selection, not keepalive
// (yamux handles its own keepalives). 30s was excessive and generated
// noisy DEBUG logs (N_clients × N_servers pings every 30s).
func (ce *Client) pingSessionsLoop(ctx context.Context) {
ticker := time.NewTicker(30 * time.Second)
ticker := time.NewTicker(1 * time.Hour)
defer ticker.Stop()

// Do an initial ping immediately.
Expand All @@ -552,11 +555,11 @@ func (ce *Client) pingSessions() {
rtt, err := ses.Ping()
if err != nil {
ce.log.WithError(err).WithField("server", ses.RemotePK()).
Debug("Ping failed, keeping previous latency measurement")
Trace("Ping failed, keeping previous latency measurement")
continue
}
ses.SetLastPing(rtt)
ce.log.WithField("server", ses.RemotePK()).WithField("rtt", rtt).
Debug("Session ping measured")
Trace("Session ping measured")
}
}