Bring Windows script to parity with bash script #13808
Merged
+63
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
cderv
force-pushed
the
windows/quarto-dev-script-update
branch
from
33b7a97 to
e09fb8e
Compare
Ports commit b44cb08 from Bash script to Windows. Enables --cached-only flag in dev mode to prevent network fetches during development, matching Bash behavior. Also sets DENO_DIR to point to the vendored deno_cache directory so dependencies are found when using --cached-only. Original commit: b44cb08 "turn on cached-only for dev as well, add puppeteer deps to cache"
cderv
force-pushed
the
windows/quarto-dev-script-update
branch
from
e09fb8e to
3ca8315
Compare
Ports DENO_DIR configuration from configure.sh (line 79) to configure.cmd. Without this, configure.cmd uses Deno's default cache location instead of the vendored deno_cache directory, causing --cached-only failures. Matches Bash behavior: uses QUARTO_DENO_DIR if set, otherwise defaults to $QUARTO_BIN_PATH/deno_cache.
Fix DENO_DIR misconfiguration causing tests to miss populated cache, resulting in redundant dependency downloads. Tests now use cache populated by vendor.sh and vendor.cmd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems some changes where missed in Deno 2 update
This PR tries to bring feature parity for dev version regarding Deno 2