fix(what-changed): use array args instead of shell syntax in run() calls#301
Open
TerminalGravity wants to merge 1 commit intomainfrom
Open
fix(what-changed): use array args instead of shell syntax in run() calls#301TerminalGravity wants to merge 1 commit intomainfrom
TerminalGravity wants to merge 1 commit intomainfrom
Conversation
run() uses execFileSync without a shell, so shell operators like 2>/dev/null and || were being passed as literal git arguments, causing silent failures. Replace with proper array args and existing git.ts helpers (getDiffFiles) with built-in fallback logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
what-changed.tswas passing shell syntax (2>/dev/null,||operators) torun(), which usesexecFileSyncwithout a shell. These shell operators were passed as literal git arguments, causing silent failures.Fix
run()calls withgetDiffFiles(ref)helper (already has proper fallback logic)run(git log ... || ...)with array args + explicit fallback checkRelated: #302 (broader cleanup of shell syntax across all tools)