fix(#302): remove shell syntax from run() calls in 4 tools#303
Open
TerminalGravity wants to merge 2 commits intomainfrom
Open
fix(#302): remove shell syntax from run() calls in 4 tools#303TerminalGravity wants to merge 2 commits intomainfrom
TerminalGravity wants to merge 2 commits intomainfrom
Conversation
run() uses execFileSync without a shell, so shell operators like 2>/dev/null and || were being passed as literal git arguments, causing silent failures. Replace with proper array args and existing git.ts helpers (getDiffFiles) with built-in fallback logic.
Convert sharpen-followup, checkpoint, session-handoff, and sequence-tasks to use array args with run() or execFileSync directly for non-git commands. Eliminates silent failures from shell operators (2>/dev/null, pipes, ||) being passed as literal args to execFileSync. Part of #302.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes shell syntax passed to
run()(which usesexecFileSyncwithout a shell) in:getDiffFiles/getStagedFileshelpersaddCmd && git commitwith sequentialrun()array callscommand -vviarun()withexecFileSync('which'); replacedgh pr liststring with properexecFileSync('gh')callgit ls-files | headwith array call + JS slicePart of #302. Batch 2 (following PR #301 which fixed what-changed.ts).