fix: remove shell syntax from run() in 4 tools#305
Open
TerminalGravity wants to merge 2 commits intomainfrom
Open
fix: remove shell syntax from run() in 4 tools#305TerminalGravity wants to merge 2 commits intomainfrom
TerminalGravity wants to merge 2 commits intomainfrom
Conversation
Replace shell syntax (pipes, redirects, 2>/dev/null) passed to run() with proper array args and Node.js equivalents: - token-audit: use Node fs for line/byte counting and tail reads - enrich-agent-task: filter git ls-files output in JS instead of grep/head pipes - clarify-intent: use execFileSync for tsc, Node fs for finding test files - audit-workspace: use array args for git diff, Node fs for counting test files scan-sessions.ts was already clean (uses fs directly, not run()). Closes the remaining files from #302.
Replace shell operators (2>/dev/null, pipes, &&, ||) passed to run() which uses execFileSync without a shell: - sharpen-followup: use array args for diff/status calls - checkpoint: split staging + commit into separate run() calls - sequence-tasks: use array args for ls-files, slice in JS - session-handoff: use execFileSync for 'which' and 'gh' directly All calls now use proper array args or dedicated execFileSync. Fixes part of #302.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes shell syntax passed to
run()(which usesexecFileSyncwithout a shell) in:diff/statuscalls&&staging+commit into separaterun()calls, removed deadaddCmdvariablels-files, JS.slice()instead of| headexecFileSync('which')instead ofcommand -v ... 2>/dev/null, directexecFileSync('gh')with try/catch instead of|| echoPart of #302. 4 of 9 affected files now fixed (PR #301 fixed
what-changed.ts).All tests pass, clean
tsc --noEmit.