Add KD-tree conflict detection benchmark slice#40
Open
ArizmendiWan wants to merge 1 commit intoopen-rmf:mainfrom
Open
Add KD-tree conflict detection benchmark slice#40ArizmendiWan wants to merge 1 commit intoopen-rmf:mainfrom
ArizmendiWan wants to merge 1 commit intoopen-rmf:mainfrom
Conversation
Signed-off-by: ArizmendiWan <2311602492@qq.com>
2 tasks
arjo129
reviewed
Apr 9, 2026
Member
There was a problem hiding this comment.
This is somewhat interesting. However, as Dijkstra said pre-mature optimization is the root of all evil. I opened #41 out of curiosity to see if such a kd-tree collision check is actually valueable here. I took the collision checking code and integrated it with the negotiation code. I then ran benchmarks on both branches and had gemini write a small summary of the resultant data.
TBH, from what I see I really small gains from using such a method. I suspect the bottleneck is elsewhere - that being said this is still a welcome addition. Perhaps a lower hanging fruit would be to switch from optimal search during the conflict negotiation to Explicit-Estimation Search or Focal Search.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a first slice for evaluating faster conflict detection in
mapfnegotiation by introducing an experimental KD-tree broad phase for proposal conflict checks.What Changed
ConflictDetectionAlgorithm::{Baseline, KdTree}anddetect_conflicts_for_proposals(...)Why
This is meant to test whether a spatial broad phase can reduce candidate pair enumeration before exact conflict checking, especially in sparse workloads, without changing planner semantics.
Verification
Run locally with:
Observed comparison from the report example:
GenAI Use
Generated-by:
OpenAI Codex (v0.115.0) with GPT-5.4