Refactor prompt library migration and label governance alignment#748
Merged
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (116)
📝 WalkthroughSummary by CodeRabbitRelease Notes
WalkthroughThis PR executes a comprehensive refactoring and migration of a 71-prompt library from a nested ChangesPrompt Library Refactor & Migration
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests (beta)
|
This was referenced Jun 1, 2026
github-actions
Bot
added
area:labels
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request executes a comprehensive prompt library refactor and migration, consolidating organisation-wide reusable prompts into a root prompts/ directory while keeping GitHub control-plane specific prompts in .github/prompts/. It introduces detailed project documentation, OpenSpec proposals, execution logs, and deprecation shims for legacy prompts, alongside registering a new area:quality label. The review feedback correctly identifies a hardcoded absolute local path in the project index that needs to be repository-relative, and advises moving the migration matrix and tracking documentation to a centralized /docs/MIGRATION.md file to comply with repository guidelines.
| - [Current .github prompt library](https://github.com/lightspeedwp/.github/tree/develop/.github/prompts) | ||
| - [Root prompts directory](https://github.com/lightspeedwp/.github/tree/develop/prompts) | ||
| - [Active projects directory](https://github.com/lightspeedwp/.github/tree/develop/.github/projects/active) | ||
| - `/Users/ash/.codex/worktrees/f767/.github/AGENTS.md` |
Contributor
There was a problem hiding this comment.
This line contains a hardcoded absolute local file path (/Users/ash/...). Absolute local paths are environment-specific and will fail for other contributors or in CI/CD environments. Please use a repository-relative path instead.
Suggested change
| - `/Users/ash/.codex/worktrees/f767/.github/AGENTS.md` | |
| - [.github/AGENTS.md](../../../AGENTS.md) |
|
|
||
| - `prompts/` is the canonical location for organisation-wide reusable prompts. | ||
| - `.github/prompts/` is reserved for `.github` control-plane and repository-governance prompts. | ||
| - Migration authority: `.github/projects/active/refactor-migrate-prompts/artifacts/migration-matrix.md`. |
Contributor
There was a problem hiding this comment.
According to the repository guidelines, migration maps and notes must be documented in a central /docs/MIGRATION.md file to ensure contributors can follow migration rules across the repository. Please document the migration matrix in /docs/MIGRATION.md and update this reference.
Suggested change
| - Migration authority: `.github/projects/active/refactor-migrate-prompts/artifacts/migration-matrix.md`. | |
| - Migration authority: /docs/MIGRATION.md. |
References
- Document migration maps and notes in a central
/docs/MIGRATION.mdfile to ensure contributors can follow migration rules mentioned in README files across the repository.
Comment on lines
+29
to
+30
| - Prompt migration and classification is tracked in: | ||
| - `.github/projects/active/refactor-migrate-prompts/artifacts/migration-matrix.md` |
Contributor
There was a problem hiding this comment.
According to the repository guidelines, migration maps and notes must be documented in a central /docs/MIGRATION.md file. Please update this reference to point to /docs/MIGRATION.md once the migration matrix is documented there.
Suggested change
| - Prompt migration and classification is tracked in: | |
| - `.github/projects/active/refactor-migrate-prompts/artifacts/migration-matrix.md` | |
| - Prompt migration and classification is tracked in /docs/MIGRATION.md. |
References
- Document migration maps and notes in a central
/docs/MIGRATION.mdfile to ensure contributors can follow migration rules mentioned in README files across the repository.
github-actions
Bot
removed
type:refactor
Contributor
🔍 Reviewer Summary for PR #748CI Status: ❌ Recommendations
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prompts/with a canonical matrix and OpenSpec project pack.github/promptsmoved/merged files and update both prompt README boundariesarea:qualityin.github/labels.ymland docs, then sync issue usageValidation
docs/LABELING.md,docs/LABEL_STRATEGY.md,docs/LABEL_INVENTORY.md(pass)gh issue viewand logs under active project artifactsReferences
.github/projects/active/refactor-migrate-prompts/artifacts/