feat!: Add ListOptions to RepositoriesService.ListAllTopics

[Not-Dhananjay-Mishra]

BREAKING CHANGE: RepositoriesService.ListAllTopics now accept one more parameter ListOptions for pagination.

RepositoriesService.ListAllTopics also support pagination acc to docs.

Related: #3976

[Not-Dhananjay-Mishra]

Interesting, generated test for RepositoriesService.ListAllTopicsIter failed.

[gmlewis]

Does it pass locally?

[gmlewis]

This is the report:

testing .
{
		"name": "n",
		"value": "v",
		"created_at": "2006-01-02T15:04:05Z",
		"updated_at": "2006-01-02T15:04:05Z",
		"visibility": "v",
		"selected_repositories_url": "s",
		"selected_repository_ids": [1,2,3]
	}
--- FAIL: TestRepositoriesService_ListAllTopicsIter (0.00s)
    github-iterators_test.go:6452: Unexpected error: json: cannot unmarshal array into Go value of type github.repositoryTopics
    github-iterators_test.go:6456: client.Repositories.ListAllTopicsIter call 1 got 1 items; want 7
    github-iterators_test.go:6465: Unexpected error: json: cannot unmarshal array into Go value of type github.repositoryTopics
    github-iterators_test.go:6469: client.Repositories.ListAllTopicsIter call 2 got 1 items; want 2
    github-iterators_test.go:6489: Unexpected error: GET http://127.0.0.1:34173/api-v3/repos/topics: 404  []

[Not-Dhananjay-Mishra]

Does it pass locally?

It passes for RepositoriesService.ListAllTopics
I didn't run test script after go generate ./...

[Not-Dhananjay-Mishra]

So that test fail because it expect a object inside array, but with this case array contain strings...

[Not-Dhananjay-Mishra]

@gmlewis should I update gen-iterators.go to handle this case in this PR?

[gmlewis]

@gmlewis should I update gen-iterators.go to handle this case in this PR?

Yes, I'm expecting that as we handle all these edge cases, that gen-iterators.go will need to be enhanced to handle all of these.

If you prefer, you can create an issue and have someone else or myself work on enhancing gen-iterators.go or you can work on it yourself... I'm fine either way.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.53%. Comparing base (5bdc954) to head (422dfe2).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3978   +/-   ##
=======================================
  Coverage   93.52%   93.53%           
=======================================
  Files         207      207           
  Lines       17569    17589   +20     
=======================================
+ Hits        16432    16452   +20     
  Misses        937      937           
  Partials      200      200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gmlewis]

Thank you, @Not-Dhananjay-Mishra and @alexandear!
LGTM.
Merging.