Skip to content

Conversation

@gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Feb 9, 2026

Fixes: #3979.
Relates to: #3978.

cc: @Not-Dhananjay-Mishra

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.52%. Comparing base (b02895e) to head (555f453).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3980   +/-   ##
=======================================
  Coverage   93.52%   93.52%           
=======================================
  Files         207      207           
  Lines       17569    17569           
=======================================
  Hits        16432    16432           
  Misses        937      937           
  Partials      200      200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis gmlewis added NeedsReview PR is awaiting a review before merging. and removed NeedsReview PR is awaiting a review before merging. labels Feb 9, 2026
@gmlewis
Copy link
Collaborator Author

gmlewis commented Feb 9, 2026

@Not-Dhananjay-Mishra - I'm going to call it a night... so I'll go ahead and merge this so as to not hold you up.
Feel free to add any comments you have even after I merge.
I tested this on your use case, and all tests passed, so hopefully you won't run into any problems.

@gmlewis gmlewis merged commit 5bdc954 into google:master Feb 9, 2026
8 checks passed
@gmlewis gmlewis deleted the i3979-gen-iterators-strings branch February 9, 2026 04:15
@Not-Dhananjay-Mishra
Copy link
Contributor

Thank you @gmlewis for merging this ❤️.
LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update gen-iterators.go to handle edge cases

2 participants