Skip to content

feat!: Add ListOptions to RepositoriesService.ListAllTopics #3978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmlewis merged 3 commits into from
Feb 9, 2026
Merged

feat!: Add ListOptions to RepositoriesService.ListAllTopics #3978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f5ebbf
ListAllTopics now support pagination
Not-Dhananjay-Mishra Feb 9, 2026
4b73e2d
Merge branch 'master' into listalltopics
Not-Dhananjay-Mishra Feb 9, 2026
422dfe2
quick fix
Not-Dhananjay-Mishra Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion github/gen-iterators.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ type method struct {
// This is needed for methods that internally unmarshal a wrapper struct
// even though they return a slice.
var customTestJSON = map[string]string{
// Uncomment in #3978: "ListAllTopics": `{"names": []}`,
"ListAllTopics": `{"names": []}`,
"ListUserInstallations": `{"installations": []}`,
}

Expand Down
31 changes: 31 additions & 0 deletions github/github-iterators.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

72 changes: 72 additions & 0 deletions github/github-iterators_test.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion github/repos.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1928,8 +1928,13 @@ type repositoryTopics struct {
// GitHub API docs: https://docs.github.com/rest/repos/repos#get-all-repository-topics
//
//meta:operation GET /repos/{owner}/{repo}/topics
func (s *RepositoriesService) ListAllTopics(ctx context.Context, owner, repo string) ([]string, *Response, error) {
func (s *RepositoriesService) ListAllTopics(ctx context.Context, owner, repo string, opts *ListOptions) ([]string, *Response, error) {
u := fmt.Sprintf("repos/%v/%v/topics", owner, repo)
u, err := addOptions(u, opts)
if err != nil {
return nil, nil, err
}

req, err := s.client.NewRequest("GET", u, nil)
if err != nil {
return nil, nil, err
Expand Down
13 changes: 9 additions & 4 deletions github/repos_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3476,11 +3476,16 @@ func TestRepositoriesService_ListAllTopics(t *testing.T) {
mux.HandleFunc("/repos/o/r/topics", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "GET")
testHeader(t, r, "Accept", mediaTypeTopicsPreview)
testFormValues(t, r, values{
"page": "1",
"per_page": "30",
})
fmt.Fprint(w, `{"names":["go", "go-github", "github"]}`)
})

ctx := t.Context()
got, _, err := client.Repositories.ListAllTopics(ctx, "o", "r")
opts := &ListOptions{Page: 1, PerPage: 30}
got, _, err := client.Repositories.ListAllTopics(ctx, "o", "r", opts)
if err != nil {
t.Fatalf("Repositories.ListAllTopics returned error: %v", err)
}
Expand All @@ -3492,12 +3497,12 @@ func TestRepositoriesService_ListAllTopics(t *testing.T) {

const methodName = "ListAllTopics"
testBadOptions(t, methodName, func() (err error) {
_, _, err = client.Repositories.ListAllTopics(ctx, "\n", "\n")
_, _, err = client.Repositories.ListAllTopics(ctx, "\n", "\n", opts)
return err
})

testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
got, resp, err := client.Repositories.ListAllTopics(ctx, "o", "r")
got, resp, err := client.Repositories.ListAllTopics(ctx, "o", "r", opts)
if got != nil {
t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got)
}
Expand All @@ -3516,7 +3521,7 @@ func TestRepositoriesService_ListAllTopics_emptyTopics(t *testing.T) {
})

ctx := t.Context()
got, _, err := client.Repositories.ListAllTopics(ctx, "o", "r")
got, _, err := client.Repositories.ListAllTopics(ctx, "o", "r", nil)
if err != nil {
t.Fatalf("Repositories.ListAllTopics returned error: %v", err)
}
Expand Down
Loading