eth: add fillTransaction, drop raw field#803
Open
bomanaps wants to merge 2 commits into
Open
Conversation
4 tasks
s1na
suggested changes
May 27, 2026
| FilledTransaction: | ||
| oneOf: | ||
| - $ref: '#/components/schemas/Transaction4844UnsignedWithSidecar' | ||
| - $ref: '#/components/schemas/Transaction4844Unsigned' |
| type: array | ||
| items: | ||
| $ref: '#/components/schemas/bytes' | ||
| commitments: |
Contributor
There was a problem hiding this comment.
We might need to update these to support the more recent cell proofs
Contributor
Author
There was a problem hiding this comment.
for the post-PeerDAS sidecar shape would you prefer we mirror the engine API pattern with a separate Transaction4844UnsignedWithSidecarV2 cell proofs variant added alongside the existing one in FilledTransaction.oneOf, replace the current proofs field outright since the spec ships through-fork, or keep proofs as bytes[] with a fork conditional description?
| name: Transaction result | ||
| schema: | ||
| $ref: '#/components/schemas/bytes' | ||
| examples: |
Contributor
There was a problem hiding this comment.
Example could have been kept btw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#512