eth: add eth_fillTransaction, fix result of eth_signTransaction#512
Closed
s1na wants to merge 2 commits into
Closed
eth: add eth_fillTransaction, fix result of eth_signTransaction#512s1na wants to merge 2 commits into
s1na wants to merge 2 commits into
Conversation
Contributor
Author
|
I've updated the PR with support for generation and verification of blob sidecars. The proposal is as follows: If the transaction arguments contain a non-empty list of blobs, then, fillTransaction will:
And later verify or compute blob hashes from those commitments. |
This was referenced Oct 21, 2025
4 tasks
bomanaps
suggested changes
May 19, 2026
| - $ref: '#/components/schemas/TransactionLegacyUnsigned' | ||
| FillTransactionResult: | ||
| type: object | ||
| title: Encoded and raw unsigned transaction object. |
Contributor
There was a problem hiding this comment.
On RPC call, we agreed to drop the raw encoded payload from FillTransactionResult and keep only the filled tx, which addresses Nethermind's security concern. Whenever you get a chance could you please push the changes so we have this update ready before ACDE on Thursday for broader client feedback, with the first security concern already addressed?
Contributor
Author
|
Closing in favor of #803 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #508
While adding spec for eth_fillTransaction I noticed that the spec for eth_signTransaction deviates from the geth implementation. I'm not sure yet how other clients implement this.