Skip to content

eth: add fillTransaction, drop raw field #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bomanaps wants to merge 2 commits into
base: main
Choose a base branch
from
Open

eth: add fillTransaction, drop raw field #803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99c07f6
eth: add fillTransaction, drop raw field
bomanaps May 20, 2026
280c356
address review comments
bomanaps May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/eth/fill.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
- name: eth_fillTransaction
summary: Fills in missing transaction fields to be signed and submitted.
params:
- name: Transaction
required: true
schema:
$ref: '#/components/schemas/GenericTransaction'
result:
name: Transaction result
schema:
$ref: '#/components/schemas/FillTransactionResult'
9 changes: 5 additions & 4 deletions src/eth/sign.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@
schema:
$ref: '#/components/schemas/GenericTransaction'
result:
name: Encoded transaction
name: Transaction result
schema:
$ref: '#/components/schemas/bytes'
$ref: '#/components/schemas/SignTransactionResult'
examples:
Copy link
Copy Markdown
Contributor

@s1na s1na May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example could have been kept btw

- name: eth_signTransaction example
params:
Expand All @@ -46,5 +46,6 @@
to: '0xd46e8dd67c5d32be8058bb8eb970870f07244567'
value: '0x9184e72a'
result:
name: Encoded transaction
value: '0xa3f20717a250c2b0b729b7e5becbff67fdaef7e0699da4de7ca5895b02a170a12d887fd3b17bfdce3481f10bea41f45ba9f709d39ce8325427b57afcfc994cee1b'
name: Transaction result
value:
raw: '0xa3f20717a250c2b0b729b7e5becbff67fdaef7e0699da4de7ca5895b02a170a12d887fd3b17bfdce3481f10bea41f45ba9f709d39ce8325427b57afcfc994cee1b'
69 changes: 69 additions & 0 deletions src/schemas/transaction.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,33 @@ Transaction4844Unsigned:
title: chainId
description: Chain ID that this transaction is valid on
$ref: '#/components/schemas/uint'
Transaction4844UnsignedWithSidecar:
title: Unsigned 4844 transaction with sidecar
type: object
allOf:
- $ref: '#/components/schemas/Transaction4844Unsigned'
- title: EIP-4844 transaction signature properties.
required:
- blobs
- commitments
- proofs
properties:
blobs:
title: blobs
description: Raw blob data.
type: array
items:
$ref: '#/components/schemas/bytes'
commitments:
Copy link
Copy Markdown
Contributor

@s1na s1na May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to update these to support the more recent cell proofs

Copy link
Copy Markdown
Contributor Author

@bomanaps bomanaps May 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the post-PeerDAS sidecar shape would you prefer we mirror the engine API pattern with a separate Transaction4844UnsignedWithSidecarV2 cell proofs variant added alongside the existing one in FilledTransaction.oneOf, replace the current proofs field outright since the spec ships through-fork, or keep proofs as bytes[] with a fork conditional description?

title: Blob commitments.
type: array
items:
$ref: '#/components/schemas/bytes'
proofs:
title: Blob proofs.
type: array
items:
$ref: '#/components/schemas/bytes'
AccessListEntry:
title: Access list entry
type: object
Expand Down Expand Up @@ -550,6 +577,18 @@ GenericTransaction:
type: array
items:
$ref: '#/components/schemas/bytes'
commitments:
title: commitments
description: List of blob commitments as per EIP-4844.
type: array
items:
$ref: '#/components/schemas/bytes'
proofs:
title: proofs
description: List of blob proofs as per EIP-4844.
type: array
items:
$ref: '#/components/schemas/bytes'
chainId:
title: chainId
description: Chain ID that this transaction is valid on.
Expand All @@ -558,3 +597,33 @@ GenericTransaction:
title: authorizationList
description: EIP-7702 authorization list
$ref: '#/components/schemas/AuthorizationList'
SignTransactionResult:
type: object
title: Encoded and raw signed transaction object.
required:
- raw
- tx
properties:
raw:
title: raw
$ref: '#/components/schemas/bytes'
tx:
title: tx
$ref: '#/components/schemas/TransactionSigned'
FilledTransaction:
oneOf:
- $ref: '#/components/schemas/Transaction7702Unsigned'
- $ref: '#/components/schemas/Transaction4844UnsignedWithSidecar'
- $ref: '#/components/schemas/Transaction4844Unsigned'
Copy link
Copy Markdown
Contributor

@s1na s1na May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want 7702 tx too

- $ref: '#/components/schemas/Transaction1559Unsigned'
- $ref: '#/components/schemas/Transaction2930Unsigned'
- $ref: '#/components/schemas/TransactionLegacyUnsigned'
FillTransactionResult:
type: object
title: Filled unsigned transaction object.
required:
- tx
properties:
tx:
title: tx
$ref: '#/components/schemas/FilledTransaction'
Loading