fix: ensure terminal properly resizes after startup script failure#49
Closed
cdr-robot wants to merge 1 commit into
Closed
fix: ensure terminal properly resizes after startup script failure#49cdr-robot wants to merge 1 commit into
cdr-robot wants to merge 1 commit into
Conversation
This change fixes a bug where the web terminal doesn't fit the screen properly when a startup script fails, causing text at the bottom of the terminal to be hidden. The solution adds a delayed second call to fitAddon.fit() after alert changes to ensure proper terminal sizing. Fixes #46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fitAddon.fit()after terminal alerts change to ensure proper sizingTest plan
Fixes #46
Workspace URL: https://demo.coder.com/ben/issue-46
🤖 Generated with Claude Code