Skip to content

fix: ensure terminal properly resizes after startup script failure #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cdr-robot wants to merge 1 commit into from
Closed

fix: ensure terminal properly resizes after startup script failure #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion site/src/pages/TerminalPage/TerminalPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,15 @@ const TerminalPage: FC = () => {
agent={workspaceAgent}
status={connectionStatus}
onAlertChange={() => {
// First fit might not calculate correctly, apply a small delay and fit again
fitAddonRef.current?.fit();

// Apply a second fit after a small delay to ensure terminal size is correct
// This fixes the issue where text at the bottom of the terminal is hidden
// when startup scripts fail
setTimeout(() => {
fitAddonRef.current?.fit();
}, 100);
}}
/>
<div
Expand Down Expand Up @@ -400,4 +408,4 @@ const styles = {
}),
} satisfies Record<string, Interpolation<Theme>>;

export default TerminalPage;
export default TerminalPage;
Loading