Skip to content

Remove false positive error log for morph targets #24407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kristoff3r wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −7
Open

Remove false positive error log for morph targets #24407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions crates/bevy_render/src/mesh/morph.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ use bevy_ecs::{
resource::Resource,
world::{FromWorld, World},
};
use bevy_log::error;
use bevy_mesh::{
morph::{MorphAttributes, MorphBuildError, MAX_MORPH_WEIGHTS, MAX_TEXTURE_WIDTH},
Mesh,
Expand Down Expand Up @@ -212,12 +211,7 @@ impl RenderMorphTargetAllocator {
RenderMorphTargetAllocator::Image {
ref mut mesh_id_to_image,
} => {
if mesh_id_to_image.remove(&mesh_id).is_none() {
error!(
"Attempted to free a morph target allocation that wasn't allocated: {:?}",
mesh_id
);
}
mesh_id_to_image.remove(&mesh_id);
}
RenderMorphTargetAllocator::Storage => {
// Do nothing. Morph target displacements are managed by the
Expand Down
Loading