Remove false positive error log for morph targets#24407
Open
kristoff3r wants to merge 1 commit into
Open
Conversation
kristoff3r
added
D-Trivial
kristoff3r
added
C-Usability
greeble-dev
approved these changes
May 24, 2026
Contributor
greeble-dev
left a comment
greeble-dev
left a comment
There was a problem hiding this comment.
From a glance I think it would be possible to change the RenderAsset API so that RenderMesh::unload_asset does have access to RenderMesh::morph_targets? But seems reasonable to do a quick fix for 0.19.
greeble-dev
added
the
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
When mesh assets are prepared, an image is allocated only if the mesh has any morph targets. When unloading the asset an error log is always printed if that image cannot be found, even if it was never allocated. This leads to a bunch of error messages that aren't actionable.
Solution
Remove the error log, as we don't have enough bookkeeping to output it correctly.
Testing
None