Skip to content

Add RenderScheduleOrder resource to allow for RenderApp Schedule changes#23513

Merged
alice-i-cecile merged 6 commits intobevyengine:mainfrom
Zeophlite:pre-render-startup
Mar 28, 2026
Merged

Add RenderScheduleOrder resource to allow for RenderApp Schedule changes#23513
alice-i-cecile merged 6 commits intobevyengine:mainfrom
Zeophlite:pre-render-startup

Conversation

@Zeophlite
Copy link
Copy Markdown
Contributor

@Zeophlite Zeophlite commented Mar 25, 2026 •
edited
Loading

Objective

  • Render schedules are static, compared to the main schedules in the main world that can be dynamically added with the MainScheduleOrder resource
  • This is necessary to allow BRP introspection of schedules in the Render world (see BRP Add schedule.graph endpoint #23452 )

Solution

  • Add RenderScheduleOrder resource that allows for ordering of Render schedules

Testing

@Zeophlite Zeophlite requested a review from atlv24 March 25, 2026 14:30
@Zeophlite Zeophlite added the A-Rendering Drawing game state to the screen label Mar 25, 2026
@github-project-automation github-project-automation bot moved this to Needs SME Triage in Rendering Mar 25, 2026
@Zeophlite Zeophlite added D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Mar 25, 2026
@Zeophlite Zeophlite mentioned this pull request Mar 25, 2026
Merged
@Zeophlite Zeophlite force-pushed the pre-render-startup branch 2 times, most recently from 4530c9f to 5560bd6 Compare March 25, 2026 14:44
@Zeophlite Zeophlite force-pushed the pre-render-startup branch from 5560bd6 to fdf7e9d Compare March 25, 2026 15:24
@alice-i-cecile
Copy link
Copy Markdown
Member

alice-i-cecile commented Mar 25, 2026

I'm not sure I understand the rationale well enough here. Can you restate the problem we're trying to solve for me using more words?

@atlv24
Copy link
Copy Markdown
Contributor

atlv24 commented Mar 25, 2026

So, I don't think this is the right approach. You can do this in a renderstartup system: just check if your resource is already initialized, and only do so if it hasn't been. The render world is never wiped, so you can store that state downstream and we don't need a RenderStartup change to accomodate this. Am i missing something?

@alice-i-cecile alice-i-cecile added S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Mar 25, 2026
@Zeophlite
Copy link
Copy Markdown
Contributor Author

Zeophlite commented Mar 25, 2026

Hmm okay I can be convinced on that, but I still need the RenderMainScheduleOrder to schedule things outside the main Render schedule (that way things like #23452 work) - will remove PreRenderStartup

@Zeophlite Zeophlite changed the title Add PreRenderStartup schedule and RenderMainScheduleOrder resource Add RenderMainScheduleOrder resource to allow for RenderApp Schedule changes Mar 25, 2026
@Zeophlite
Copy link
Copy Markdown
Contributor Author

Zeophlite commented Mar 25, 2026

Okay so this is much simpler now - this follows the same as the main world Main schedule phases (see MainScheduleOrder )

@Zeophlite Zeophlite added S-Needs-Review Needs reviewer attention (from anyone!) to move forward and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Mar 26, 2026
@kfc35 kfc35 self-requested a review March 26, 2026 21:31
@Zeophlite Zeophlite requested review from atlv24 and removed request for atlv24 March 27, 2026 00:04
kfc35
kfc35 approved these changes Mar 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@kfc35 kfc35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t have any blocking comments

@alice-i-cecile
Copy link
Copy Markdown
Member

alice-i-cecile commented Mar 27, 2026

I like the new direction much better here.

@Zeophlite Zeophlite changed the title Add RenderMainScheduleOrder resource to allow for RenderApp Schedule changes Add RenderScheduleOrder resource to allow for RenderApp Schedule changes Mar 27, 2026
@Zeophlite Zeophlite added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Mar 27, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 28, 2026
BenjaminBrienen
BenjaminBrienen reviewed Mar 28, 2026
View reviewed changes
crates/bevy_render/src/lib.rs
}

fn run_render_schedule(world: &mut World) {
world.run_schedule(Render);
Copy link
Copy Markdown
Contributor

@BenjaminBrienen BenjaminBrienen Mar 28, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The name of this function should probably be updated

Merged via the queue into bevyengine:main with commit 61a294d Mar 28, 2026
40 checks passed
@github-project-automation github-project-automation bot moved this from Needs SME Triage to Done in Rendering Mar 28, 2026
github-merge-queue bot pushed a commit that referenced this pull request Mar 30, 2026
@Zeophlite @kfc35
Add BRP to render app (#23446)
3c98d53 
# Objective

- BRP on the `RenderApp`

## Solution

- Add type registry to `RenderApp`
- Add BRP systems to render app
- Add HTTP listener to extra port

I suggest hiding whitespace for reviewing:

<img width="422" height="360" alt="image"
src="https://github.com/user-attachments/assets/3d76eafb-40f5-42f6-8752-c9d94f81d378"
/>

## Related:

- #23513
- #23447
- #23452

## Testing

- CI
- in terminal 1 run `cargo run --example client
--features="bevy_remote"`
- in terminal 2 run `curl
-d'{"jsonrpc":"2.0","method":"world.list_resources","id":1,"params":{}}'
-X POST -H "Accept: applcation/json" -H "Content-Type: application/json"
http://127.0.0.1:15702`
- in terminal 2 run `curl
-d'{"jsonrpc":"2.0","method":"world.list_resources","id":1,"params":{}}'
-X POST -H "Accept: applcation/json" -H "Content-Type: application/json"
http://127.0.0.1:15703`

---------

Co-authored-by: Kevin Chen <chen.kevin.f@gmail.com>
splo pushed a commit to splo/bevy that referenced this pull request Mar 31, 2026
@Zeophlite @splo
Add RenderScheduleOrder resource to allow for RenderApp `Schedule…
05ced36 
…` changes (bevyengine#23513)

# Objective

- Render schedules are static, compared to the main schedules in the
main world that can be dynamically added with the `MainScheduleOrder`
resource
- This is necessary to allow BRP introspection of schedules in the
Render world (see bevyengine#23452 )

## Solution

- Add `RenderScheduleOrder` resource that allows for ordering of
`Render` schedules

## Testing

- CI
- bevyengine#23446
splo pushed a commit to splo/bevy that referenced this pull request Mar 31, 2026
@Zeophlite @kfc35 @splo
Add BRP to render app (bevyengine#23446)
7afe675 
- BRP on the `RenderApp`

- Add type registry to `RenderApp`
- Add BRP systems to render app
- Add HTTP listener to extra port

I suggest hiding whitespace for reviewing:

<img width="422" height="360" alt="image"
src="https://github.com/user-attachments/assets/3d76eafb-40f5-42f6-8752-c9d94f81d378"
/>

- bevyengine#23513
- bevyengine#23447
- bevyengine#23452

- CI
- in terminal 1 run `cargo run --example client
--features="bevy_remote"`
- in terminal 2 run `curl
-d'{"jsonrpc":"2.0","method":"world.list_resources","id":1,"params":{}}'
-X POST -H "Accept: applcation/json" -H "Content-Type: application/json"
http://127.0.0.1:15702`
- in terminal 2 run `curl
-d'{"jsonrpc":"2.0","method":"world.list_resources","id":1,"params":{}}'
-X POST -H "Accept: applcation/json" -H "Content-Type: application/json"
http://127.0.0.1:15703`

---------

Co-authored-by: Kevin Chen <chen.kevin.f@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile Awaiting requested review from alice-i-cecile

3 more reviewers

@BenjaminBrienen BenjaminBrienen BenjaminBrienen left review comments

@kfc35 kfc35 kfc35 approved these changes

@atlv24 atlv24 atlv24 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Rendering
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Zeophlite @alice-i-cecile @atlv24 @kfc35 @BenjaminBrienen