Add BRP to render app by Zeophlite · Pull Request #23446 · bevyengine/bevy

Zeophlite · 2026-03-21T09:37:45Z

Objective

BRP on the RenderApp

Solution

Add type registry to RenderApp
Add BRP systems to render app
Add HTTP listener to extra port

I suggest hiding whitespace for reviewing:

Testing

CI
in terminal 1 run cargo run --example client --features="bevy_remote"
in terminal 2 run curl -d'{"jsonrpc":"2.0","method":"world.list_resources","id":1,"params":{}}' -X POST -H "Accept: applcation/json" -H "Content-Type: application/json" http://127.0.0.1:15702
in terminal 2 run curl -d'{"jsonrpc":"2.0","method":"world.list_resources","id":1,"params":{}}' -X POST -H "Accept: applcation/json" -H "Content-Type: application/json" http://127.0.0.1:15703

github-actions · 2026-03-21T10:06:54Z

The generated examples/README.md is out of sync with the example metadata in Cargo.toml or the example readme template. Please run cargo run -p build-templated-pages -- update examples to update it, and commit the file change.

crates/bevy_remote/src/http.rs

crates/bevy_remote/src/lib.rs

crates/bevy_remote/src/http.rs

examples/remote/render_client.rs

crates/bevy_remote/src/lib.rs

crates/bevy_remote/src/http.rs

Co-authored-by: Kevin Chen <chen.kevin.f@gmail.com>

crates/bevy_remote/src/lib.rs

crates/bevy_render/src/lib.rs

…` changes (#23513) # Objective - Render schedules are static, compared to the main schedules in the main world that can be dynamically added with the `MainScheduleOrder` resource - This is necessary to allow BRP introspection of schedules in the Render world (see #23452 ) ## Solution - Add `RenderScheduleOrder` resource that allows for ordering of `Render` schedules ## Testing - CI - #23446

alice-i-cecile

I don't think that this warrants release notes: it's not going to be meaningful to users who have never used Bevy (or most Bevy users).

kfc35

LGTM

crates/bevy_ecs/src/schedule/schedule.rs

Co-authored-by: Kevin Chen <chen.kevin.f@gmail.com>

atlv24

i am not very familiar with BRP but this looks fine

# Objective - List schedules in BRP ## Solution - Add the endpoint - Add to `Schedules` some tracking of `temporarily_removed` (schedule removed to execute) and `empty_labels` (no `Schedule` for that label) ## Related: - bevyengine#23452 - bevyengine#23446 ## Testing - in terminal 1 run `cargo run --example server --features="bevy_remote"` - in terminal 2 run `curl -d'{"jsonrpc":"2.0","method":"schedule.list","id":1,"params":{}}' -X POST -H "Accept: applcation/json" -H "Content-Type: application/json" http://127.0.0.1:15702` <details><summary>Response</summary> ```json { "jsonrpc": "2.0", "id": 1, "result": { "empty_schedule_labels": [ "FixedPreUpdate", "FixedUpdate" ], "schedule_labels": [ "Startup", "First", "RunFixedMainLoop", "PostStartup", "FixedFirst", "StateTransition", "PreUpdate", "PostUpdate", "Update", "PreStartup", "SpawnScene", "Last", "FixedLast", "FixedPostUpdate", "FixedMain" ], "unavailable_schedule_labels": [ "Main", "RemoteLast" ] } } ``` </details> --------- Co-authored-by: Kevin Chen <chen.kevin.f@gmail.com>

# Objective - Describe the graph for a given schedule ## Solution - Add endpoint `schedule.graph` ## Related: - bevyengine#23447 - bevyengine#23446 ## Testing - in terminal 1 run `cargo run --example server --features="bevy_remote"` - in terminal 2 run `curl -d'{"jsonrpc":"2.0","method":"schedule.graph","id":1,"params":{"schedule_name":"First"}}' -X POST -H "Accept: applcation/json" -H "Content-Type: application/json" http://127.0.0.1:15702 ` <details><summary>Response</summary> ```json { "jsonrpc": "2.0", "id": 1, "result": { "systemsets": [ { "key": "SystemSetKey(1v1)", "method": "SystemTypeSet:bevy_ecs::message::update::message_update_system" }, { "key": "SystemSetKey(2v1)", "method": "MessageUpdateSystems" }, { "key": "SystemSetKey(3v1)", "method": "SystemTypeSet:bevy_time::time_system" }, { "key": "SystemSetKey(4v1)", "method": "TimeSystems" }, { "key": "SystemSetKey(5v1)", "method": "SystemTypeSet:bevy_render::view::window::screenshot::clear_screenshots" }, { "key": "SystemSetKey(6v1)", "method": "SystemTypeSet:bevy_ecs::schedule::executor::ApplyDeferred" }, { "key": "SystemSetKey(7v1)", "method": "SystemTypeSet:bevy_ui::widget::viewport::viewport_picking" }, { "key": "SystemSetKey(8v1)", "method": "PostInput" }, { "key": "SystemSetKey(9v1)", "method": "SystemTypeSet:bevy_picking::input::mouse_pick_events" }, { "key": "SystemSetKey(10v1)", "method": "Input" }, { "key": "SystemSetKey(11v1)", "method": "SystemTypeSet:bevy_picking::input::touch_pick_events" } ], "hierarchy_nodes": [ "Set(SystemSetKey(11v1))", "Set(SystemSetKey(10v1))", "System(SystemKey(6v1))", "Set(SystemSetKey(9v1))", "System(SystemKey(5v1))", "Set(SystemSetKey(8v1))", "Set(SystemSetKey(7v1))", "System(SystemKey(4v1))", "Set(SystemSetKey(6v1))", "Set(SystemSetKey(5v1))", "System(SystemKey(3v1))", "Set(SystemSetKey(4v1))", "Set(SystemSetKey(3v1))", "System(SystemKey(2v1))", "Set(SystemSetKey(2v1))", "Set(SystemSetKey(1v1))", "System(SystemKey(1v1))" ], "hierarchy_edges": [ [ "Set(SystemSetKey(1v1))", "System(SystemKey(1v1))" ], [ "Set(SystemSetKey(3v1))", "System(SystemKey(2v1))" ], [ "Set(SystemSetKey(8v1))", "System(SystemKey(4v1))" ], [ "Set(SystemSetKey(2v1))", "System(SystemKey(1v1))" ], [ "Set(SystemSetKey(7v1))", "System(SystemKey(4v1))" ], [ "Set(SystemSetKey(4v1))", "System(SystemKey(2v1))" ], [ "Set(SystemSetKey(9v1))", "System(SystemKey(5v1))" ], [ "Set(SystemSetKey(10v1))", "System(SystemKey(6v1))" ], [ "Set(SystemSetKey(5v1))", "System(SystemKey(3v1))" ], [ "Set(SystemSetKey(10v1))", "System(SystemKey(5v1))" ], [ "Set(SystemSetKey(11v1))", "System(SystemKey(6v1))" ] ], "dependency_nodes": [ "System(SystemKey(1v1))", "Set(SystemSetKey(1v1))", "Set(SystemSetKey(2v1))", "System(SystemKey(2v1))", "Set(SystemSetKey(3v1))", "Set(SystemSetKey(4v1))", "System(SystemKey(3v1))", "Set(SystemSetKey(5v1))", "Set(SystemSetKey(6v1))", "System(SystemKey(4v1))", "Set(SystemSetKey(7v1))", "Set(SystemSetKey(8v1))", "System(SystemKey(5v1))", "Set(SystemSetKey(9v1))", "Set(SystemSetKey(10v1))", "System(SystemKey(6v1))", "Set(SystemSetKey(11v1))" ], "dependency_edges": [ [ "Set(SystemSetKey(2v1))", "Set(SystemSetKey(10v1))" ], [ "Set(SystemSetKey(10v1))", "Set(SystemSetKey(8v1))" ], [ "System(SystemKey(3v1))", "Set(SystemSetKey(6v1))" ], [ "System(SystemKey(5v1))", "System(SystemKey(6v1))" ], [ "Set(SystemSetKey(4v1))", "Set(SystemSetKey(8v1))" ], [ "Set(SystemSetKey(4v1))", "Set(SystemSetKey(10v1))" ], [ "Set(SystemSetKey(2v1))", "Set(SystemSetKey(8v1))" ], [ "Set(SystemSetKey(1v1))", "System(SystemKey(3v1))" ] ] } } ``` </details> From the above response, the below graph can be generated. Hierarchy edges are blue, dependency edges are red. System nodes are implied by hierarchy from Set to System. <img width="1543" height="347" alt="first" src="https://github.com/user-attachments/assets/80ac7e80-2a28-4246-80cc-29337bad4383" /> <details><summary>GraphViz Source</summary> ``` digraph { "Set(SystemSetKey(1v1))" [label="message_update_system"] "Set(SystemSetKey(2v1))" [label="MessageUpdateSystems"] "Set(SystemSetKey(3v1))" [label="time_system"] "Set(SystemSetKey(4v1))" [label="TimeSystems"] "Set(SystemSetKey(5v1))" [label="clear_screenshots"] "Set(SystemSetKey(6v1))" [label="ApplyDeferred"] "Set(SystemSetKey(7v1))" [label="viewport_picking"] "Set(SystemSetKey(8v1))" [label="PostInput"] "Set(SystemSetKey(9v1))" [label="mouse_pick_events"] "Set(SystemSetKey(10v1))" [label="Input"] "Set(SystemSetKey(11v1))" [label="touch_pick_events"] // implied nodes "System(SystemKey(1v1))" [label="implied message_update_system", shape=rectangle] "System(SystemKey(2v1))" [label="implied time_system", shape=rectangle] "System(SystemKey(3v1))" [label="implied clear_screenshots", shape=rectangle] "System(SystemKey(4v1))" [label="implied viewport_picking", shape=rectangle] "System(SystemKey(5v1))" [label="implied mouse_pick_events", shape=rectangle] "System(SystemKey(6v1))" [label="implied touch_pick_events", shape=rectangle] // hierarchy "Set(SystemSetKey(1v1))" -> "System(SystemKey(1v1))" [color=blue] "Set(SystemSetKey(3v1))" -> "System(SystemKey(2v1))" [color=blue] "Set(SystemSetKey(8v1))" -> "System(SystemKey(4v1))" [color=blue] "Set(SystemSetKey(2v1))" -> "System(SystemKey(1v1))" [color=blue] "Set(SystemSetKey(7v1))" -> "System(SystemKey(4v1))" [color=blue] "Set(SystemSetKey(4v1))" -> "System(SystemKey(2v1))" [color=blue] "Set(SystemSetKey(9v1))" -> "System(SystemKey(5v1))" [color=blue] "Set(SystemSetKey(10v1))" -> "System(SystemKey(6v1))" [color=blue] "Set(SystemSetKey(5v1))" -> "System(SystemKey(3v1))" [color=blue] "Set(SystemSetKey(10v1))" -> "System(SystemKey(5v1))" [color=blue] "Set(SystemSetKey(11v1))" -> "System(SystemKey(6v1))" [color=blue] // dependencies "Set(SystemSetKey(2v1))" -> "Set(SystemSetKey(10v1))" [color=red] "Set(SystemSetKey(10v1))" -> "Set(SystemSetKey(8v1))" [color=red] "System(SystemKey(3v1))" -> "Set(SystemSetKey(6v1))" [color=red] "System(SystemKey(5v1))" -> "System(SystemKey(6v1))" [color=red] "Set(SystemSetKey(4v1))" -> "Set(SystemSetKey(8v1))" [color=red] "Set(SystemSetKey(4v1))" -> "Set(SystemSetKey(10v1))" [color=red] "Set(SystemSetKey(2v1))" -> "Set(SystemSetKey(8v1))" [color=red] "Set(SystemSetKey(1v1))" -> "System(SystemKey(3v1))" [color=red] } ``` </details> --------- Co-authored-by: Kevin Chen <chen.kevin.f@gmail.com> Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>

…` changes (bevyengine#23513) # Objective - Render schedules are static, compared to the main schedules in the main world that can be dynamically added with the `MainScheduleOrder` resource - This is necessary to allow BRP introspection of schedules in the Render world (see bevyengine#23452 ) ## Solution - Add `RenderScheduleOrder` resource that allows for ordering of `Render` schedules ## Testing - CI - bevyengine#23446

- BRP on the `RenderApp` - Add type registry to `RenderApp` - Add BRP systems to render app - Add HTTP listener to extra port I suggest hiding whitespace for reviewing: <img width="422" height="360" alt="image" src="https://github.com/user-attachments/assets/3d76eafb-40f5-42f6-8752-c9d94f81d378" /> - bevyengine#23513 - bevyengine#23447 - bevyengine#23452 - CI - in terminal 1 run `cargo run --example client --features="bevy_remote"` - in terminal 2 run `curl -d'{"jsonrpc":"2.0","method":"world.list_resources","id":1,"params":{}}' -X POST -H "Accept: applcation/json" -H "Content-Type: application/json" http://127.0.0.1:15702` - in terminal 2 run `curl -d'{"jsonrpc":"2.0","method":"world.list_resources","id":1,"params":{}}' -X POST -H "Accept: applcation/json" -H "Content-Type: application/json" http://127.0.0.1:15703` --------- Co-authored-by: Kevin Chen <chen.kevin.f@gmail.com>

Shatur · 2026-04-05T00:50:18Z

crates/bevy_render/Cargo.toml

+reflect_auto_register = ["bevy_app/reflect_auto_register"]
+reflect_functions = ["bevy_app/reflect_functions"]
+
+default = ["reflect_auto_register", "reflect_functions"]


@Zeophlite I think this shouldn't be enabled by default. Otherwise once you enable anything that requires rendering, it enables reflect_auto_register. I think this should be controlled by reflect_auto_register on bevy.

This causes reflection tests to fail in my crate.

#23667 to remove

Add BRP to render app

232094c

Zeophlite added the D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes label Mar 21, 2026

Cleanup

2c6903f

Zeophlite force-pushed the brp-render branch from 1e02aac to 2c6903f Compare March 21, 2026 15:25

Zeophlite marked this pull request as ready for review March 21, 2026 15:39

Zeophlite added S-Needs-Help The author needs help finishing this PR. A-Dev-Tools Tools used to debug Bevy applications. C-Feature A new feature, making something new possible labels Mar 21, 2026

kfc35 self-requested a review March 21, 2026 16:15

Zeophlite added this to the 0.19 milestone Mar 21, 2026

kfc35 reviewed Mar 21, 2026

View reviewed changes

Zeophlite mentioned this pull request Mar 21, 2026

BRP Add schedule.list endpoint #23447

Merged

Zeophlite and others added 2 commits March 22, 2026 23:24

Apply suggestions from code review

28efb21

Co-authored-by: Kevin Chen <chen.kevin.f@gmail.com>

Review

346add3

Zeophlite mentioned this pull request Mar 24, 2026

BRP Add schedule.graph endpoint #23452

Merged

Zeophlite added 3 commits March 24, 2026 21:56

Merge render_client example back into client example

5fc8e0b

Merge remote-tracking branch 'origin/main' into brp-render

837f401

Fix url

5caf2f0

kfc35 reviewed Mar 25, 2026

View reviewed changes

crates/bevy_remote/src/lib.rs Outdated Show resolved Hide resolved

Zeophlite added 5 commits March 25, 2026 21:35

Add PreRenderStartup, PreRender and PostRender schedules

63725b1

Merge remote-tracking branch 'origin/main' into brp-render

30c06b1

Use PreRenderStartup and PostRender schedules

25f8dd1

fmt

2733bf2

with_method_main/with_method_render

6c62e42

Zeophlite mentioned this pull request Mar 25, 2026

Add RenderScheduleOrder resource to allow for RenderApp Schedule changes #23513

Merged

Zeophlite added 2 commits March 25, 2026 23:27

Add RenderMainScheduleOrder resource to manage render schedules

508bd1a

Use RenderMainScheduleOrder

9e6fbf9

Zeophlite force-pushed the brp-render branch from 49344d1 to 9e6fbf9 Compare March 25, 2026 15:28

Zeophlite removed the S-Needs-Help The author needs help finishing this PR. label Mar 25, 2026

Zeophlite force-pushed the brp-render branch from c229b79 to 2205cb8 Compare March 26, 2026 23:41

Zeophlite added 3 commits March 27, 2026 07:44

Merge remote-tracking branch 'origin/main' into brp-render

5207d05

Rever example to main

1aac36d

Re-add example changes

6def24d

Zeophlite commented Mar 26, 2026

View reviewed changes

crates/bevy_render/src/lib.rs Outdated Show resolved Hide resolved

Zeophlite added 3 commits March 28, 2026 10:34

Merge remote-tracking branch 'origin/main' into brp-render

e2d79f1

Fix

aea68db

Add release notes for brp

50d83f7

alice-i-cecile requested a review from atlv24 March 28, 2026 03:41

alice-i-cecile requested changes Mar 28, 2026

View reviewed changes

Zeophlite added 3 commits March 28, 2026 12:25

Docs

9ada7e3

rm release notes

af92b1d

fmt

6e021ac

alice-i-cecile self-requested a review March 28, 2026 04:44

Doc

9420da4

kfc35 approved these changes Mar 28, 2026

View reviewed changes

crates/bevy_ecs/src/schedule/schedule.rs Outdated Show resolved Hide resolved

Update crates/bevy_ecs/src/schedule/schedule.rs

b77e4fd

Co-authored-by: Kevin Chen <chen.kevin.f@gmail.com>

atlv24 approved these changes Mar 30, 2026

View reviewed changes

Zeophlite added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Mar 30, 2026

alice-i-cecile approved these changes Mar 30, 2026

View reviewed changes

alice-i-cecile added this pull request to the merge queue Mar 30, 2026

Merged via the queue into bevyengine:main with commit 3c98d53 Mar 30, 2026
44 checks passed

Shatur reviewed Apr 5, 2026

View reviewed changes

Uh oh!

Conversation

Zeophlite commented Mar 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Objective

Solution

Related:

Testing

Uh oh!

github-actions bot commented Mar 21, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alice-i-cecile left a comment

Choose a reason for hiding this comment

Uh oh!

kfc35 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

atlv24 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Shatur Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Zeophlite Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Zeophlite commented Mar 21, 2026 •

edited

Loading

Shatur Apr 5, 2026 •

edited

Loading