Open
Conversation
IceSentry
added
A-Rendering
atlv24
approved these changes
Feb 14, 2026
kristoff3r
approved these changes
Feb 15, 2026
| ), | ||
| ); | ||
|
|
||
| render_app.add_schedule(RenderGraph::base_schedule()); |
Contributor
There was a problem hiding this comment.
There's a small footgun here: if any of the plugins that are added above insert systems into this schedule they will be removed, because this overwrites the implicit schedule that they create. That's the reason Render::base_schedule() is currently added inside ExtractPlugin.
I made add_schedule print a warning though, and we're planning to move ExtractPlugin to bevy_extract, when that happens we'll have a better place to put this. So it might be fine for now.
Contributor
Author
There was a problem hiding this comment.
Yeah, I wasn't totally sure where to put it. For now it's fine because they aren't used anywhere else and the only place I'm planning on adding it is also fine with this limitation.
IceSentry
added
S-Ready-For-Final-Review
JMS55
approved these changes
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
RenderGraphSolution
RenderGraphSytemsthat contains all the important phases of theRenderGraphexecutionTesting
Note
This is needed to fix diagnostic recording of gpu timestamps.