Skip to content

ignore ambiguities on MainWorld and caches#22951

Open
atlv24 wants to merge 3 commits intobevyengine:mainfrom
atlv24:ad/render-ambiguities-3
Open

ignore ambiguities on MainWorld and caches#22951
atlv24 wants to merge 3 commits intobevyengine:mainfrom
atlv24:ad/render-ambiguities-3

Conversation

@atlv24
Copy link
Contributor

@atlv24 atlv24 commented Feb 14, 2026

Objective

  • bring down the RenderApp ambiguity count by about ~1500

Solution

  • ignore ambiguity on MainWorld in extract (this is fine, it doesnt/shouldnt matter what order we read MainWorld in, and mutating it in extract is cursed)
  • caches and other things of the form of HashSet<Entity, Thing> don't care about write order

Testing

  • this doesnt change behavior just ignores ambiguities that dont matter

@atlv24 atlv24 force-pushed the ad/render-ambiguities-3 branch from 9358107 to 2eaea3c Compare February 14, 2026 08:50
@atlv24 atlv24 added A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Feb 14, 2026
@github-project-automation github-project-automation bot moved this to Needs SME Triage in Rendering Feb 14, 2026
@andriyDev andriyDev added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Needs SME Triage

Development

Successfully merging this pull request may close these issues.

3 participants