Enable RenderApp Ambiguity Detection#22954
Open
atlv24 wants to merge 4 commits intobevyengine:mainfrom
Open
Conversation
…_specialization of different materials ambiguous with each other
…re_preprocess_pipelines and thus not have pipelines ready for bindgroup creation
atlv24
added
A-Rendering
Contributor
Author
|
How did CI pass even though my other patches havent merged yet? There should be like 1500 ambiguities still without them merged. |
IceSentry
approved these changes
Feb 14, 2026
andriyDev
approved these changes
Feb 15, 2026
andriyDev
added
S-Ready-For-Final-Review
mockersf
reviewed
Feb 15, 2026
| 0, | ||
| "Main app has unexpected ambiguities among the following schedules: \n{main_app_ambiguities:#?}.", | ||
| ); | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| let render_app_ambiguities = count_ambiguities(app.sub_app(bevy_render::RenderApp)); | |
| assert_eq!( | |
| render_app_ambiguities.total(), | |
| 0, | |
| "Render app has unexpected ambiguities among the following schedules: \n{render_app_ambiguities:#?}.", | |
| ); | |
| } |
Member
You configured the test to look for ambiguities, but not to crash if there are some |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Testing