Skip to content

Pbr GltfExtensionHandler: hashes to slashes #22943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alice-i-cecile merged 4 commits into from
Feb 17, 2026
Merged

Pbr GltfExtensionHandler: hashes to slashes #22943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
340e72b
switch from hashes to slashes for asset paths
ChristopherBiscardi Feb 13, 2026
35d17b1
update migration guide
ChristopherBiscardi Feb 13, 2026
b9c5ce4
rs in codeblocks
ChristopherBiscardi Feb 13, 2026
32cd296
Merge remote-tracking branch 'upstream' into hash-to-slash
ChristopherBiscardi Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/bevy_pbr/src/gltf.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ impl GltfExtensionHandler for GltfExtensionHandlerPbr {
fn on_root(&mut self, load_context: &mut LoadContext<'_>, _gltf: &gltf::Gltf) {
// create the `StandardMaterial` for the glTF `DefaultMaterial` so
// it can be accessed when meshes don't have materials.
let std_label = format!("{}#std", GltfAssetLabel::DefaultMaterial);
let std_label = format!("{}/std", GltfAssetLabel::DefaultMaterial);

load_context.add_labeled_asset(
std_label,
Expand All @@ -119,7 +119,7 @@ impl GltfExtensionHandler for GltfExtensionHandlerPbr {
material_asset: &GltfMaterial,
material_label: &str,
) {
let std_label = format!("{}#std", material_label);
let std_label = format!("{}/std", material_label);

load_context.add_labeled_asset(
std_label,
Expand All @@ -136,7 +136,7 @@ impl GltfExtensionHandler for GltfExtensionHandlerPbr {
entity: &mut EntityWorldMut,
material_label: &str,
) {
let std_label = format!("{}#std", material_label);
let std_label = format!("{}/std", material_label);
let handle = load_context.get_label_handle::<StandardMaterial>(std_label);

entity.insert(MeshMaterial3d(handle));
Expand Down
14 changes: 14 additions & 0 deletions release-content/migration-guides/gltf_pbr.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,20 @@ pull_requests: [22569]

Previously, `bevy_gltf` depended on `bevy_pbr`. This meant scene definition was tightly coupled to rendering. This dependency has been inverted, to allow `bevy_gltf` to function without any of the rendering stack present.

In 0.18, loading a material sub-asset would return a `Handle<StandardMaterial>`.

```rs
let handle: Handle<StandardMaterial> = asset_server.load("models/animated/Fox.glb#Material0");
```

In 0.19, loading a material sub-asset loads a `GltfMaterial` to accurately represent the data in the glTF file.
To load the `StandardMaterial`, use the `/std` suffix when the `bevy_pbr` feature is turned on (the feature is on by default).

```rs
let handle: Handle<GltfMaterial> = asset_server.load("models/animated/Fox.glb#Material0");
let handle_std: Handle<StandardMaterial> = asset_server.load("models/animated/Fox.glb#Material0/std");
```

You can disable PBR rendering by initializing `PbrPlugin` as so:

```rs
Expand Down
Loading