Pbr GltfExtensionHandler: hashes to slashes#22943
Open
ChristopherBiscardi wants to merge 3 commits intobevyengine:mainfrom
Open
Pbr GltfExtensionHandler: hashes to slashes#22943ChristopherBiscardi wants to merge 3 commits intobevyengine:mainfrom
ChristopherBiscardi wants to merge 3 commits intobevyengine:mainfrom
Conversation
IceSentry
approved these changes
Feb 13, 2026
andriyDev
approved these changes
Feb 13, 2026
Contributor
andriyDev
left a comment
There was a problem hiding this comment.
I'd prefer we add a test that we can actually load this extra material, but I'll not block on that.
We should also change our asset loader stuff to ban these characters from asset labels, but that's a separate PR.
andriyDev
approved these changes
Feb 13, 2026
Contributor
|
Great catch, thankyou! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
The asset server doesn't handle paths with multiple
#in them well, which leads to users trying to load the new-style standard material (postGltfMaterial/pbr inversion) like this:and failing with
Solution
On recommendation from @andriyDev , switching to use slashes fixes the pathing issue.
Testing
Used the gltf animated fox example to load a material as indicated above, and apply it to a 100x100x100 cube:
The migration guide uses paths since so are the source of truth for the asset server, and there is currently no
GltfAssetLabelfor the new standard material handling. (This should be fixed also in a different PR).